Skip to content

typo: FILED_ID_PROP -> FIELD_ID_PROP #1497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2025
+7 −7
Merged

typo: FILED_ID_PROP -> FIELD_ID_PROP #1497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions crates/iceberg/src/avro/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ use crate::spec::{
use crate::{Error, ErrorKind, Result, ensure_data_valid};

const ELEMENT_ID: &str = "element-id";
const FILED_ID_PROP: &str = "field-id";
const FIELD_ID_PROP: &str = "field-id";
const KEY_ID: &str = "key-id";
const VALUE_ID: &str = "value-id";
const UUID_BYTES: usize = 16;
Expand Down Expand Up @@ -96,7 +96,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
avro_record_field.default = Some(Value::Null);
}
avro_record_field.custom_attributes.insert(
FILED_ID_PROP.to_string(),
FIELD_ID_PROP.to_string(),
Value::Number(Number::from(field.id)),
);

Expand Down Expand Up @@ -178,7 +178,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
custom_attributes: Default::default(),
};
field.custom_attributes.insert(
FILED_ID_PROP.to_string(),
FIELD_ID_PROP.to_string(),
Value::Number(Number::from(map.key_field.id)),
);
field
Expand All @@ -196,7 +196,7 @@ impl SchemaVisitor for SchemaToAvroSchema {
custom_attributes: Default::default(),
};
field.custom_attributes.insert(
FILED_ID_PROP.to_string(),
FIELD_ID_PROP.to_string(),
Value::Number(Number::from(map.value_field.id)),
);
field
Expand Down Expand Up @@ -444,7 +444,7 @@ impl AvroSchemaVisitor for AvroSchemaToSchema {
let mut fields = Vec::with_capacity(field_types.len());
for (avro_field, field_type) in record.fields.iter().zip_eq(field_types) {
let field_id =
Self::get_element_id_from_attributes(&avro_field.custom_attributes, FILED_ID_PROP)?;
Self::get_element_id_from_attributes(&avro_field.custom_attributes, FIELD_ID_PROP)?;

let optional = is_avro_optional(&avro_field.schema);

Expand Down Expand Up @@ -585,11 +585,11 @@ impl AvroSchemaVisitor for AvroSchemaToSchema {
})?;
let key_id = Self::get_element_id_from_attributes(
&array.fields[0].custom_attributes,
FILED_ID_PROP,
FIELD_ID_PROP,
)?;
let value_id = Self::get_element_id_from_attributes(
&array.fields[1].custom_attributes,
FILED_ID_PROP,
FIELD_ID_PROP,
)?;
let key_field = NestedField::map_key_element(key_id, key);
let value_field = NestedField::map_value_element(
Expand Down
Loading