refactor: Move memory catalog into core #1480
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
requested review from
kevinjqliu and
liurenjie1024
and removed request for
kevinjqliu
| @@ -22,12 +22,10 @@ | |||
| //! ## Scan A Table | |||
| //! | |||
| //! ```rust, ignore | |||
There was a problem hiding this comment.
It's supposed to be able to compile now?
| @@ -17,6 +17,8 @@ | |||
|
|
|||
| //! Catalog API for Apache Iceberg | |||
|
|
|||
| pub mod memory; | |||
There was a problem hiding this comment.
This is odd to me, user have to use iceberg::memory::MemoryCatalog. I would prefer to ask user to use iceberg::MemoryCatalog, iceberg::catalog::memory::MeoryCatalog, or iceberg::catalog::MemoryCatalog
|
Also we need to remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
MemoryCatalogintoicebergcrate. #1472What changes are included in this PR?
Merge memory catalog into core.
Are these changes tested?