Preliminary benchmarking framework #1463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This PR adds a preliminary benchmarking framework and the first benchmark to
iceberg-rs.The main contribution is a new
benchmarkingcrate with most of the benchmarking code. Included is the first benchmark, which tests the speed at which iceberg can project 2 columns from a table. Benchmarks are created withcriterion.A problem I ran into was making consistent latency accessing files from storage. To solve this problem, there is a new rustflag-gated
storage_benchmarkingthat acts similarly tostorage_memorybut induces a much more consistent amount of latency compared to alternatives.Are these changes tested?
Tests are not included, the code here is not included in production.