-
Notifications
You must be signed in to change notification settings - Fork 281
doc: Add a readme for the SQL catalog #1459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crates/catalog/sql/README.md
Outdated
```toml | ||
[dependencies] | ||
iceberg-catalog-sql = "X.Y.Z" | ||
sqlx = { version = "X.Y.Z", features = ["runtime-tokio", "sqlite"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be confusing if sqlx
's version is same as iceberg-catalog-sql
, I would prefer to change it to a different placeholder.
|
||
# Apache Iceberg SQL Catalog Official Native Rust Implementation | ||
|
||
[](https://crates.io/crates/iceberg-catalog-sql) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, iceberg-catalog-sql
has not been published yet. See #1460
Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
Which issue does this PR close?
ClosesAmends problems from Sqlite sql catalogs work in unit tests, but not in prod because of config mistake #1456What changes are included in this PR?
A
README.md
for the SQL catalog. Includes information on includingsqlite
database support.