Skip to content

feat(transaction): Make Transaction own base_table #1421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025

Conversation

CTTY
Copy link
Contributor

@CTTY CTTY commented Jun 8, 2025

Which issue does this PR close?

This is a part of the effort to refactor transaction commit path and enable retry for write operations.
Please find the POC here: #1400

Related Issues:

What changes are included in this PR?

  • Make Transaction own base_table instead of a reference, so we can refresh base_table using catalog within the Transaction when retry

Are these changes tested?

Using the existing unit tests

@CTTY CTTY changed the title make tx own base_table feat(transaction): Make Transaction own base_table Jun 8, 2025
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CTTY for this pr, generally looks good!

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CTTY for this pr, LGTM!

@liurenjie1024 liurenjie1024 merged commit cd103fb into apache:main Jun 10, 2025
17 checks passed
@CTTY CTTY deleted the ctty/tx-own-table branch June 10, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants