Make And expression JSON serializable using Pydantic #2560
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fokko Could you please review these changes when you have time. |
|
@Aniketsy Thanks for working on this, but I think this one is problematic, since it relies on |
|
@Fokko sure, I will wait till |
|
@Fokko I think PR on |
|
@Aniketsy Certainly, let me know if you run into anything 👍 |
Fokko
reviewed
Oct 20, 2025
|
I would recommend taking some inspiration from the |
|
@Aniketsy gentle ping on this :) |
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
d0284b5 to
dd534a8
Compare
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
6607718 to
59674ec
Compare
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
55e54cf to
536e2b8
Compare
Aniketsy
force-pushed
the
fix/json-serializable-and-expression
branch
from
e4b84dc to
6f71f21
Compare
|
@kevinjqliu Could you please take a look and help me understand why one of the tests is failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2518
This PR addresses issue by making the
Andexpression in pyiceberg.expressions fully JSON serializable using Pydantic.Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thank you !