Skip to content

refactor: remove explicit operator!= using C++20 rewrite candidates #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Jun 19, 2025

C++20 supports rewrite candidates, see https://en.cppreference.com/w/cpp/language/overload_resolution.html#Call_to_an_overloaded_operator

For x != y, all member, non-member, and built-in operator==s found are added to the set, unless there is a matching operator!=.

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less is more, thanks @mapleFU for fixing this, and thanks @lidavidm and @wgtmac for the review 🚀

@Fokko Fokko merged commit 3cf5963 into apache:main Jun 19, 2025
7 checks passed
@mapleFU mapleFU deleted the using-rewrite-candidates-for-un-equal branch June 19, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants