-
Notifications
You must be signed in to change notification settings - Fork 37
feat: metadata access support for table #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lishuxu
wants to merge
18
commits into
apache:main
Choose a base branch
from
lishuxu:feature/my-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
aa8f652
feat: static table metadata access support
7a50991
feat: static table metadata access support
0df0217
feat: static table metadata access support
f2a718d
feat: static table metadata access support
1f94b9b
feat: static table metadata access support
8c854f9
feat: static table metadata access support
675bdd8
static table metadata access support
9b10557
feat: static table metadata access support
f933198
feat: static table metadata access support
c9fe0ac
feat: static table metadata access support
a09cb8b
feat: static table metadata access support
401a019
feat: static table metadata access support
345355a
feat: static table metadata access support
fc8bf0f
Merge remote-tracking branch 'upstream/main' into feature/my-feature
9257726
feat: metadata access support for table
d95bd4b
feat: metadata access support for table
515bd86
feat: metadata access support for table
43979f2
feat: metadata access support for table
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
#include "iceberg/table.h" | ||
|
||
#include "iceberg/partition_spec.h" | ||
#include "iceberg/schema.h" | ||
#include "iceberg/sort_order.h" | ||
#include "iceberg/table_metadata.h" | ||
|
||
namespace iceberg { | ||
|
||
const std::string& Table::uuid() const { return metadata_->table_uuid; } | ||
|
||
Result<std::shared_ptr<Schema>> Table::schema() const { return metadata_->Schema(); } | ||
|
||
const std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<Schema>>>& | ||
Table::schemas() const { | ||
if (!schemas_map_) { | ||
schemas_map_ = | ||
std::make_shared<std::unordered_map<int32_t, std::shared_ptr<Schema>>>(); | ||
for (const auto& schema : metadata_->schemas) { | ||
if (schema->schema_id()) { | ||
schemas_map_->emplace(schema->schema_id().value(), schema); | ||
} | ||
} | ||
} | ||
return schemas_map_; | ||
} | ||
|
||
Result<std::shared_ptr<PartitionSpec>> Table::spec() const { | ||
return metadata_->PartitionSpec(); | ||
} | ||
|
||
const std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>>& | ||
Table::specs() const { | ||
if (!partition_spec_map_) { | ||
partition_spec_map_ = | ||
std::make_shared<std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>>(); | ||
for (const auto& spec : metadata_->partition_specs) { | ||
partition_spec_map_->emplace(spec->spec_id(), spec); | ||
} | ||
} | ||
return partition_spec_map_; | ||
} | ||
|
||
Result<std::shared_ptr<SortOrder>> Table::sort_order() const { | ||
return metadata_->SortOrder(); | ||
} | ||
|
||
const std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<SortOrder>>>& | ||
Table::sort_orders() const { | ||
if (!sort_orders_map_) { | ||
sort_orders_map_ = | ||
std::make_shared<std::unordered_map<int32_t, std::shared_ptr<SortOrder>>>(); | ||
for (const auto& order : metadata_->sort_orders) { | ||
sort_orders_map_->emplace(order->order_id(), order); | ||
} | ||
} | ||
return sort_orders_map_; | ||
} | ||
|
||
const std::unordered_map<std::string, std::string>& Table::properties() const { | ||
return metadata_->properties; | ||
} | ||
|
||
const std::string& Table::location() const { return metadata_->location; } | ||
|
||
Result<std::shared_ptr<Snapshot>> Table::current_snapshot() const { | ||
return metadata_->Snapshot(); | ||
} | ||
|
||
Result<std::shared_ptr<Snapshot>> Table::SnapshotById(int64_t snapshot_id) const { | ||
auto iter = std::ranges::find_if(metadata_->snapshots, | ||
[this, &snapshot_id](const auto& snapshot) { | ||
return snapshot->snapshot_id == snapshot_id; | ||
}); | ||
if (iter == metadata_->snapshots.end()) { | ||
return NotFound("Snapshot with ID {} is not found", snapshot_id); | ||
} | ||
return *iter; | ||
} | ||
|
||
const std::vector<std::shared_ptr<Snapshot>>& Table::snapshots() const { | ||
return metadata_->snapshots; | ||
} | ||
|
||
const std::vector<SnapshotLogEntry>& Table::history() const { | ||
return metadata_->snapshot_log; | ||
} | ||
|
||
const std::shared_ptr<FileIO>& Table::io() const { return io_; } | ||
|
||
} // namespace iceberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,13 +19,14 @@ | |
|
||
#pragma once | ||
|
||
#include <memory> | ||
#include <mutex> | ||
#include <string> | ||
#include <unordered_map> | ||
#include <vector> | ||
|
||
#include "iceberg/iceberg_export.h" | ||
#include "iceberg/result.h" | ||
#include "iceberg/snapshot.h" | ||
#include "iceberg/table_identifier.h" | ||
#include "iceberg/type_fwd.h" | ||
|
||
namespace iceberg { | ||
|
@@ -35,77 +36,88 @@ class ICEBERG_EXPORT Table { | |
public: | ||
virtual ~Table() = default; | ||
|
||
/// \brief Return the full name for this table | ||
virtual const std::string& name() const = 0; | ||
/// \brief Construct a table. | ||
/// \param[in] identifier The identifier of the table. | ||
/// \param[in] metadata The metadata for the table. | ||
/// \param[in] metadata_location The location of the table metadata file. | ||
/// \param[in] io The FileIO to read and write table data and metadata files. | ||
/// \param[in] catalog The catalog that this table belongs to. If null, the table will | ||
/// be read-only. | ||
Table(TableIdentifier identifier, std::shared_ptr<TableMetadata> metadata, | ||
std::string metadata_location, std::shared_ptr<FileIO> io, | ||
std::shared_ptr<Catalog> catalog) | ||
: identifier_(std::move(identifier)), | ||
metadata_(std::move(metadata)), | ||
metadata_location_(std::move(metadata_location)), | ||
io_(std::move(io)), | ||
catalog_(std::move(catalog)) {}; | ||
|
||
/// \brief Return the identifier of this table | ||
const TableIdentifier& name() const { return identifier_; } | ||
|
||
/// \brief Returns the UUID of the table | ||
virtual const std::string& uuid() const = 0; | ||
const std::string& uuid() const; | ||
|
||
/// \brief Refresh the current table metadata | ||
virtual Status Refresh() = 0; | ||
|
||
/// \brief Return the schema for this table | ||
virtual const std::shared_ptr<Schema>& schema() const = 0; | ||
/// \brief Return the schema for this table, return NotFoundError if not found | ||
Result<std::shared_ptr<Schema>> schema() const; | ||
|
||
/// \brief Return a map of schema for this table | ||
virtual const std::unordered_map<int32_t, std::shared_ptr<Schema>>& schemas() const = 0; | ||
const std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<Schema>>>& schemas() | ||
const; | ||
|
||
/// \brief Return the partition spec for this table | ||
virtual const std::shared_ptr<PartitionSpec>& spec() const = 0; | ||
/// \brief Return the partition spec for this table, return NotFoundError if not found | ||
Result<std::shared_ptr<PartitionSpec>> spec() const; | ||
|
||
/// \brief Return a map of partition specs for this table | ||
virtual const std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>& specs() | ||
const = 0; | ||
const std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>>& | ||
specs() const; | ||
|
||
/// \brief Return the sort order for this table | ||
virtual const std::shared_ptr<SortOrder>& sort_order() const = 0; | ||
/// \brief Return the sort order for this table, return NotFoundError if not found | ||
Result<std::shared_ptr<SortOrder>> sort_order() const; | ||
|
||
/// \brief Return a map of sort order IDs to sort orders for this table | ||
virtual const std::unordered_map<int32_t, std::shared_ptr<SortOrder>>& sort_orders() | ||
const = 0; | ||
const std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<SortOrder>>>& | ||
sort_orders() const; | ||
|
||
/// \brief Return a map of string properties for this table | ||
virtual const std::unordered_map<std::string, std::string>& properties() const = 0; | ||
const std::unordered_map<std::string, std::string>& properties() const; | ||
|
||
/// \brief Return the table's base location | ||
virtual const std::string& location() const = 0; | ||
const std::string& location() const; | ||
|
||
/// \brief Return the table's current snapshot | ||
virtual const std::shared_ptr<Snapshot>& current_snapshot() const = 0; | ||
/// \brief Return the table's current snapshot, return NotFoundError if not found | ||
Result<std::shared_ptr<Snapshot>> current_snapshot() const; | ||
|
||
/// \brief Get the snapshot of this table with the given id, or null if there is no | ||
/// matching snapshot | ||
/// \brief Get the snapshot of this table with the given id | ||
/// | ||
/// \param snapshot_id the ID of the snapshot to get | ||
/// \return the Snapshot with the given id | ||
virtual Result<std::shared_ptr<Snapshot>> snapshot(int64_t snapshot_id) const = 0; | ||
/// \return the Snapshot with the given id, return NotFoundError if not found | ||
Result<std::shared_ptr<Snapshot>> SnapshotById(int64_t snapshot_id) const; | ||
|
||
/// \brief Get the snapshots of this table | ||
virtual const std::vector<std::shared_ptr<Snapshot>>& snapshots() const = 0; | ||
const std::vector<std::shared_ptr<Snapshot>>& snapshots() const; | ||
|
||
/// \brief Get the snapshot history of this table | ||
/// | ||
/// \return a vector of history entries | ||
virtual const std::vector<std::shared_ptr<HistoryEntry>>& history() const = 0; | ||
|
||
/// \brief Create a new table scan for this table | ||
/// | ||
/// Once a table scan is created, it can be refined to project columns and filter data. | ||
virtual std::unique_ptr<TableScan> NewScan() const = 0; | ||
|
||
/// \brief Create a new append API to add files to this table and commit | ||
virtual std::shared_ptr<AppendFiles> NewAppend() = 0; | ||
|
||
/// \brief Create a new transaction API to commit multiple table operations at once | ||
virtual std::unique_ptr<Transaction> NewTransaction() = 0; | ||
|
||
/// TODO(wgtmac): design of FileIO is not finalized yet. We intend to use an | ||
/// IO-less design in the core library. | ||
// /// \brief Returns a FileIO to read and write table data and metadata files | ||
// virtual std::shared_ptr<FileIO> io() const = 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we need to keep |
||
|
||
/// \brief Returns a LocationProvider to provide locations for new data files | ||
virtual std::unique_ptr<LocationProvider> location_provider() const = 0; | ||
const std::vector<SnapshotLogEntry>& history() const; | ||
|
||
/// \brief Returns a FileIO to read and write table data and metadata files | ||
const std::shared_ptr<FileIO>& io() const; | ||
|
||
private: | ||
const TableIdentifier identifier_; | ||
const std::shared_ptr<TableMetadata> metadata_; | ||
const std::string metadata_location_; | ||
std::shared_ptr<FileIO> io_; | ||
std::shared_ptr<Catalog> catalog_; | ||
|
||
mutable std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<Schema>>> | ||
schemas_map_; | ||
mutable std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<PartitionSpec>>> | ||
partition_spec_map_; | ||
mutable std::shared_ptr<std::unordered_map<int32_t, std::shared_ptr<SortOrder>>> | ||
sort_orders_map_; | ||
}; | ||
|
||
} // namespace iceberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.