Skip to content

Add license checker #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 17, 2024
Merged

Add license checker #10

merged 7 commits into from
Dec 17, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Dec 13, 2024

To make sure that we have the right headers 👍

exit 1
else
echo -e "RAT checks passed."
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a empty line in the end here?

# specific language governing permissions and limitations
# under the License.

name: "Run License Check"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider the apache/skywalking-eyes@main Github action which Apache ORC currently uses: https://github.com/apache/orc/blob/main/.github/workflows/build_and_test.yml#L178-L189

It looks simpler to use IMHO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that looks much simpler indeed. Question, do you know why it needs the Github token?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fancy, let me change to Skywalking!

Copy link
Contributor Author

@Fokko Fokko Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍 Tnx @wgtmac and @raulcd

@Fokko Fokko requested a review from nastra December 16, 2024 09:43
Copy link
Member

@wgtmac wgtmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fokko and @raulcd!

Copy link
Collaborator

@zhjwpku zhjwpku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline to the end of a file.

Fokko and others added 3 commits December 17, 2024 09:34
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
@Fokko Fokko requested review from raulcd and zhjwpku December 17, 2024 08:35
Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fokko . Just the minor nit of the removal of the whitespace

Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
@Fokko Fokko requested a review from zhjwpku December 17, 2024 08:59
@Fokko
Copy link
Contributor Author

Fokko commented Dec 17, 2024

Thanks @raulcd @zhjwpku Let's add pre-commit so we can add the yaml format hook to avoid manual formatting of yaml. Machines are much better at that :) Anyone interested in adding that?

@Fokko Fokko merged commit b5c3d45 into apache:main Dec 17, 2024
4 checks passed
@Fokko Fokko deleted the fd-add-rat-check branch December 17, 2024 09:02
@zhjwpku
Copy link
Collaborator

zhjwpku commented Dec 17, 2024

Thanks @raulcd @zhjwpku Let's add pre-commit so we can add the yaml format hook to avoid manual formatting of yaml. Machines are much better at that :) Anyone interested in adding that?

I can give it a look, thanks.

@raulcd
Copy link
Member

raulcd commented Dec 17, 2024

Thanks @zhjwpku , I've created: #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants