-
Notifications
You must be signed in to change notification settings - Fork 37
Add license checker #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dev/check-license
Outdated
exit 1 | ||
else | ||
echo -e "RAT checks passed." | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a empty line in the end here?
# specific language governing permissions and limitations | ||
# under the License. | ||
|
||
name: "Run License Check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider the apache/skywalking-eyes@main
Github action which Apache ORC currently uses: https://github.com/apache/orc/blob/main/.github/workflows/build_and_test.yml#L178-L189
It looks simpler to use IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that looks much simpler indeed. Question, do you know why it needs the Github token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems required to comment on the PR:
https://github.com/apache/skywalking-eyes/blob/3ea9df11bb3a5a85665377d1fd10c02edecf2c40/pkg/review/header.go#L62-L64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fancy, let me change to Skywalking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a newline to the end of a file.
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Fokko . Just the minor nit of the removal of the whitespace
Co-authored-by: Junwang Zhao <zhjwpku@gmail.com>
Thanks @raulcd @zhjwpku Let's add pre-commit so we can add the yaml format hook to avoid manual formatting of yaml. Machines are much better at that :) Anyone interested in adding that? |
I can give it a look, thanks. |
To make sure that we have the right headers 👍