Skip to content

Conversation

yunchipang
Copy link
Contributor

Description

Implements a new API that allows reading a file slice by providing a base file path and a list of log file paths.

existing 2 options to read file slices:

  • read_file_slice_by_base_file_path: base file only (no log files)
  • read_file_slice: requires pre-built FileSlice object (automatic log discovery)

This new read_file_slice_from_paths API allows users to manually specify which log files to include with a base file.

closes #402

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

Copy link

codecov bot commented Sep 16, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.57%. Comparing base (150eeef) to head (f19d652).

Files with missing lines Patch % Lines
crates/core/src/file_group/reader.rs 50.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #446      +/-   ##
==========================================
- Coverage   88.90%   88.57%   -0.34%     
==========================================
  Files          49       49              
  Lines        2713     2739      +26     
==========================================
+ Hits         2412     2426      +14     
- Misses        301      313      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yunchipang yunchipang force-pushed the 402-read-file-slice-from-paths branch from d60c6f8 to dfb3169 Compare September 16, 2025 03:48
@yunchipang yunchipang force-pushed the 402-read-file-slice-from-paths branch from dfb3169 to f19d652 Compare September 16, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API to read a file slice from a base file and a list of log files

1 participant