Skip to content

Conversation

xushiyan
Copy link
Member

@xushiyan xushiyan commented Jul 13, 2025

Description

Add test tables of v8.

For #379

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

Signed-off-by: Shiyan Xu <2701446+xushiyan@users.noreply.github.com>
@xushiyan xushiyan added this to the release-0.5.0 milestone Jul 13, 2025
@xushiyan xushiyan linked an issue Jul 13, 2025 that may be closed by this pull request
Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good base test infra on which we can build further. Few suggestions for future work:

  1. The current PR focuses on general v8 tables but lacks timeline-specific test scenarios. We need tables with tv = 8, tlv = v1 (where tv is table version and tlv is timeline layout version), a compacted LSM timeline (with compacted parquet files), multilayer timeline.
  2. Migration and compatibility scenarios testing.

Let's merge this PR and we can add more tests once we land this PR and #395. One thing maybe we can do in the current PR is to add a README under crates/test/data to document all the test resources under the folder. This helps in understanding and also useful for maintainability. We did something similar in Presto and Trino:
https://github.com/prestodb/presto/blob/7d0f5bda49e9d5eed0a9c0bde38a513462be341d/presto-hive/src/test/resources/hudi-testing-data.md
https://github.com/trinodb/trino/blob/2a0ff847336060ec2a64e6cb43020eb9ea36db37/plugin/trino-hudi/src/test/resources/README.md

Copy link

codecov bot commented Jul 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (35cbc6e) to head (d161ba8).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   88.89%   88.89%           
=======================================
  Files          49       49           
  Lines        2711     2711           
=======================================
  Hits         2410     2410           
  Misses        301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xushiyan xushiyan requested a review from codope July 14, 2025 05:43
@xushiyan
Copy link
Member Author

@codope sounds good. we need a lot more test cases. we can generate as needed when implementing relevant functions. In addition, we need some general cases like mentioned in #392

Copy link
Member

@codope codope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xushiyan Do you want to add README in this PR or a followup?

@xushiyan xushiyan changed the title test: add v8 test tables test: add basic v8 test tables Jul 14, 2025
@codope codope merged commit 3937170 into apache:main Jul 14, 2025
13 checks passed
@xushiyan xushiyan deleted the add-v8-test-tables branch July 14, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prepare test data for v8 tables

2 participants