-
Notifications
You must be signed in to change notification settings - Fork 52
test: add basic v8 test tables #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Shiyan Xu <2701446+xushiyan@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good base test infra on which we can build further. Few suggestions for future work:
- The current PR focuses on general v8 tables but lacks timeline-specific test scenarios. We need tables with tv = 8, tlv = v1 (where tv is table version and tlv is timeline layout version), a compacted LSM timeline (with compacted parquet files), multilayer timeline.
- Migration and compatibility scenarios testing.
Let's merge this PR and we can add more tests once we land this PR and #395. One thing maybe we can do in the current PR is to add a README under crates/test/data
to document all the test resources under the folder. This helps in understanding and also useful for maintainability. We did something similar in Presto and Trino:
https://github.com/prestodb/presto/blob/7d0f5bda49e9d5eed0a9c0bde38a513462be341d/presto-hive/src/test/resources/hudi-testing-data.md
https://github.com/trinodb/trino/blob/2a0ff847336060ec2a64e6cb43020eb9ea36db37/plugin/trino-hudi/src/test/resources/README.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 88.89% 88.89%
=======================================
Files 49 49
Lines 2711 2711
=======================================
Hits 2410 2410
Misses 301 301 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xushiyan Do you want to add README in this PR or a followup?
Description
Add test tables of v8.
For #379
How are the changes test-covered