Skip to content

Conversation

csviri
Copy link
Contributor

@csviri csviri commented Aug 28, 2025

What is the purpose of the change

Add an commented out section to helm values.yaml that showcases how to use config.yaml instead of flink-conf.yaml.

Verifying this change

The underlying mechanism was already implemented before, was just hard to find.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changes to the CustomResourceDescriptors: no
  • Core observer or reconciler logic that is regularly executed: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri marked this pull request as draft August 28, 2025 13:49
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri changed the title Express is values.yaml that config.yaml can be used Showcase in Helm chart values.yaml that config.yaml can be used Sep 22, 2025
@csviri csviri changed the title Showcase in Helm chart values.yaml that config.yaml can be used [FLINK-38409] Showcase in Helm chart values.yaml that config.yaml can be used Sep 22, 2025
@csviri csviri marked this pull request as ready for review September 22, 2025 08:54

webhook:
create: true
create: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an unintentional change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, sorry, reverted

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@mxm mxm merged commit f164dcb into apache:main Sep 23, 2025
44 of 118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants