refactor: streamline sync-to-upstream workflow and improve comments #781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add GitHub Actions workflow for automatic upstream sync
This is a test PR to verify the automatic sync workflow functionality. Expected behavior after merging to dubbo-go-pixiu/dubbo-go-pixiu:develop: 1. Workflow should trigger automatically 2. Create sync branch (auto-sync-YYYYMMDD-HHMMSS) 3. Rebase onto apache/dubbo-go-pixiu:develop 4. Remove fork-specific workflow files automatically 5. Create PR in apache/dubbo-go-pixiu 6. Comment on this PR with upstream link Success criteria: - Workflow runs without errors - Upstream PR created with this commit - Workflow files NOT present in upstream PR - Original commit author preserved Test Date: 2025-10-02 07:14:07 UTC
* test: verify upstream sync workflow This is a test PR to verify the automatic sync workflow functionality. Expected behavior after merging to dubbo-go-pixiu/dubbo-go-pixiu:develop: 1. Workflow should trigger automatically 2. Create sync branch (auto-sync-YYYYMMDD-HHMMSS) 3. Rebase onto apache/dubbo-go-pixiu:develop 4. Remove fork-specific workflow files automatically 5. Create PR in apache/dubbo-go-pixiu 6. Comment on this PR with upstream link Success criteria: - Workflow runs without errors - Upstream PR created with this commit - Workflow files NOT present in upstream PR - Original commit author preserved Test Date: 2025-10-02 07:14:07 UTC * fix: use pull_request_target to access secrets from fork PRs The pull_request event does not provide access to secrets when triggered by PRs from forks (security measure). Using pull_request_target instead, which runs in the context of the base repository and has access to secrets. This fixes the 'Input required and not supplied: token' error.
* test: verify upstream sync workflo * fix: use pull_request_target to access secrets from fork PRs The pull_request event does not provide access to secrets when triggered by PRs from forks (security measure). Using pull_request_target instead, which runs in the context of the base repository and has access to secrets. This fixes the 'Input required and not supplied: token' error. * fix: specify repository for PR comment in Step 9 When using pull_request_target, the workflow runs in the base repository context. We need to explicitly specify --repo parameter for gh pr comment to ensure it comments on the correct PR. Also added error handling to prevent workflow failure if commenting fails, since the main task (creating upstream PR) is already done. * fix: delete doc
* feat: enhance upstream sync workflow configuration * feat: refine upstream sync workflow conditions and cleanup steps * feat: add branch target check to upstream sync workflow
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #781 +/- ##
============================================
- Coverage 54.67% 16.21% -38.46%
============================================
Files 671 224 -447
Lines 78658 16723 -61935
============================================
- Hits 43006 2712 -40294
+ Misses 31981 13750 -18231
+ Partials 3671 261 -3410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Upstream Sync from Community Fork
This PR automatically syncs changes from the community fork to the upstream repository.
Original Contribution
Original PR Description
This pull request streamlines and simplifies the workflow for syncing changes from the community fork to the upstream repository. It removes fork-specific configuration and files, clarifies documentation and messaging, and improves error handling for rebase conflicts. The changes mainly affect the
.github/workflows/sync-to-upstream.ymlworkflow and remove.github/pull.yml.Summary by Sourcery
Refactor and simplify the GitHub Actions sync-to-upstream workflow by removing fork-specific configuration and files, tightening execution conditions, and improving inline documentation and error messages.
Enhancements:
CI:
Documentation:
Summary by CodeRabbit
All commits preserve original authorship.
Note: Auto-created when PR #11 was merged into
dubbo-go-pixiu/dubbo-go-pixiu:develop.cc @Similarityoung