Skip to content

Conversation

Alanxtl
Copy link
Contributor

@Alanxtl Alanxtl commented Oct 3, 2025

  • ensure samples directory is removed before cloning
  • rm useless sub git dir

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.99%. Comparing base (26606a8) to head (5a64140).
⚠️ Report is 70 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (26606a8) and HEAD (5a64140). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (26606a8) HEAD (5a64140)
1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #775       +/-   ##
============================================
- Coverage    54.67%   15.99%   -38.68%     
============================================
  Files          671      220      -451     
  Lines        78658    16332    -62326     
============================================
- Hits         43006     2613    -40393     
+ Misses       31981    13483    -18498     
+ Partials      3671      236     -3435     
Flag Coverage Δ
unittests 15.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AlexStocks AlexStocks requested a review from Copilot October 3, 2025 14:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused Git submodules and adds safety checks to ensure clean cloning operations in the CI workflow. The changes eliminate obsolete submodule references for actions-ding and review-dog while adding a directory cleanup step before cloning samples.

  • Removed unused Git submodules for actions-ding and review-dog from .gitmodules
  • Added directory cleanup logic before cloning samples in the CI workflow
  • Cleaned up the actual submodule directory reference

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.gitmodules Removed submodule entries for actions-ding and review-dog
.github/workflows/github-actions.yml Added directory cleanup before samples cloning
.github/actions/actions-ding Removed submodule commit reference

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

sonarqubecloud bot commented Oct 3, 2025

@AlexStocks
Copy link
Contributor

ci 失败,还需要看下

@Alanxtl
Copy link
Contributor Author

Alanxtl commented Oct 4, 2025

ci 失败,还需要看下

这个pr就是用来修复这个ci失败的,现在ci有clone路径被占用的问题,导致ci一直过不了,这个pr加了一个路径检测

@baerwang
Copy link
Member

baerwang commented Oct 4, 2025

ci 失败,还需要看下

这个pr就是用来修复这个ci失败的,现在ci有clone路径被占用的问题,导致ci一直过不了,这个pr加了一个路径检测

加了这个,为什么还有ci失败的?

@AlexStocks
Copy link
Contributor

先合并看看

@AlexStocks AlexStocks merged commit b47a592 into apache:develop Oct 5, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants