-
Notifications
You must be signed in to change notification settings - Fork 167
fix(ci): ensure samples directory is removed before cloning & rm useless sub git dir #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Alanxtl
commented
Oct 3, 2025
- ensure samples directory is removed before cloning
- rm useless sub git dir
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #775 +/- ##
============================================
- Coverage 54.67% 15.99% -38.68%
============================================
Files 671 220 -451
Lines 78658 16332 -62326
============================================
- Hits 43006 2613 -40393
+ Misses 31981 13483 -18498
+ Partials 3671 236 -3435
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes unused Git submodules and adds safety checks to ensure clean cloning operations in the CI workflow. The changes eliminate obsolete submodule references for actions-ding and review-dog while adding a directory cleanup step before cloning samples.
- Removed unused Git submodules for actions-ding and review-dog from .gitmodules
- Added directory cleanup logic before cloning samples in the CI workflow
- Cleaned up the actual submodule directory reference
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
.gitmodules | Removed submodule entries for actions-ding and review-dog |
.github/workflows/github-actions.yml | Added directory cleanup before samples cloning |
.github/actions/actions-ding | Removed submodule commit reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… rm useless sub git dir" This reverts commit 1a073e7.
|
ci 失败,还需要看下 |
这个pr就是用来修复这个ci失败的,现在ci有clone路径被占用的问题,导致ci一直过不了,这个pr加了一个路径检测 |
加了这个,为什么还有ci失败的? |
先合并看看 |