Skip to content

[chore](compaction) Remove useless debug info #50433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33595 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc517c66ec4ca2fbb6567fe35fc6f2b634917273, data reload: false

------ Round 1 ----------------------------------
q1	25873	5086	5021	5021
q2	2054	270	176	176
q3	10426	1258	686	686
q4	10216	1001	519	519
q5	7548	2408	2286	2286
q6	176	158	130	130
q7	903	739	600	600
q8	9316	1283	1080	1080
q9	6959	5061	5062	5061
q10	6862	2294	1860	1860
q11	482	284	277	277
q12	350	353	212	212
q13	17782	3618	3066	3066
q14	230	220	200	200
q15	520	473	509	473
q16	441	444	395	395
q17	601	840	368	368
q18	7568	7355	7017	7017
q19	1443	963	537	537
q20	320	324	226	226
q21	3934	3306	2427	2427
q22	1025	1005	978	978
Total cold run time: 115029 ms
Total hot run time: 33595 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5210	5041	5056	5041
q2	243	330	233	233
q3	2210	2762	2379	2379
q4	1434	1850	1454	1454
q5	4466	4400	4430	4400
q6	215	166	127	127
q7	1952	1908	1752	1752
q8	2553	2673	2522	2522
q9	7240	7226	7175	7175
q10	3004	3191	2706	2706
q11	566	508	486	486
q12	680	772	629	629
q13	3474	3857	3260	3260
q14	289	292	283	283
q15	527	460	467	460
q16	470	495	476	476
q17	1158	1571	1353	1353
q18	7786	7526	7417	7417
q19	782	820	883	820
q20	1953	1950	1820	1820
q21	5186	4780	4805	4780
q22	1046	1015	1012	1012
Total cold run time: 52444 ms
Total hot run time: 50585 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192393 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc517c66ec4ca2fbb6567fe35fc6f2b634917273, data reload: false

query1	1390	1074	1060	1060
query2	6219	1905	1891	1891
query3	11009	4708	4487	4487
query4	53301	24498	23455	23455
query5	5234	498	456	456
query6	356	183	186	183
query7	5068	499	291	291
query8	339	241	248	241
query9	6455	2566	2576	2566
query10	441	319	263	263
query11	15068	15022	14703	14703
query12	161	110	108	108
query13	1161	501	404	404
query14	10051	6280	6331	6280
query15	203	194	178	178
query16	6999	707	489	489
query17	1085	753	603	603
query18	1536	398	310	310
query19	192	187	162	162
query20	127	127	121	121
query21	204	125	105	105
query22	4567	4547	4548	4547
query23	34111	33219	33575	33219
query24	6577	2395	2436	2395
query25	454	453	412	412
query26	744	283	160	160
query27	2439	504	330	330
query28	3040	2145	2153	2145
query29	578	549	415	415
query30	273	223	189	189
query31	852	872	771	771
query32	68	60	62	60
query33	464	361	317	317
query34	865	858	520	520
query35	812	862	763	763
query36	958	1011	918	918
query37	123	110	83	83
query38	4126	4313	4187	4187
query39	1515	1420	1437	1420
query40	209	117	103	103
query41	53	55	49	49
query42	119	110	106	106
query43	509	517	495	495
query44	1337	814	806	806
query45	172	204	170	170
query46	843	1033	635	635
query47	1818	1869	1805	1805
query48	388	408	301	301
query49	689	506	422	422
query50	652	732	407	407
query51	4161	4267	4192	4192
query52	105	106	96	96
query53	221	257	186	186
query54	586	584	532	532
query55	84	79	80	79
query56	289	314	285	285
query57	1174	1186	1165	1165
query58	270	260	244	244
query59	2814	2938	2870	2870
query60	342	324	338	324
query61	133	127	121	121
query62	769	724	683	683
query63	229	188	191	188
query64	2014	1050	673	673
query65	4364	4214	4219	4214
query66	750	396	282	282
query67	15899	15389	15287	15287
query68	7067	836	516	516
query69	534	321	271	271
query70	1172	1147	1070	1070
query71	483	332	295	295
query72	5747	4929	4833	4833
query73	1230	664	346	346
query74	8989	8918	8738	8738
query75	3765	3209	2701	2701
query76	4251	1186	748	748
query77	609	394	281	281
query78	9963	10136	9191	9191
query79	1470	819	549	549
query80	627	514	521	514
query81	483	263	221	221
query82	184	125	97	97
query83	357	249	223	223
query84	288	104	86	86
query85	762	342	314	314
query86	327	291	274	274
query87	4376	4447	4245	4245
query88	2884	2210	2201	2201
query89	391	318	279	279
query90	2042	209	208	208
query91	144	154	109	109
query92	72	63	59	59
query93	1139	944	580	580
query94	701	394	306	306
query95	366	281	284	281
query96	486	596	279	279
query97	3126	3202	3190	3190
query98	219	205	205	205
query99	1444	1396	1256	1256
Total cold run time: 295856 ms
Total hot run time: 192393 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dc517c66ec4ca2fbb6567fe35fc6f2b634917273, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.10
query3	0.24	0.19	0.18
query4	1.58	0.19	0.18
query5	0.59	0.59	0.59
query6	1.20	0.71	0.73
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.56	0.53	0.51
query10	0.58	0.57	0.55
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.60	0.60
query14	1.25	1.16	1.18
query15	0.90	0.84	0.84
query16	0.37	0.38	0.38
query17	1.07	1.03	1.04
query18	0.21	0.20	0.20
query19	1.93	1.81	1.79
query20	0.02	0.01	0.00
query21	15.39	0.90	0.54
query22	0.76	1.08	0.72
query23	14.95	1.37	0.65
query24	7.46	0.91	1.25
query25	0.46	0.28	0.07
query26	0.64	0.17	0.13
query27	0.05	0.04	0.04
query28	9.30	0.80	0.43
query29	12.56	4.12	3.40
query30	0.25	0.09	0.06
query31	2.83	0.58	0.37
query32	3.23	0.54	0.46
query33	2.99	3.03	3.02
query34	15.61	5.13	4.46
query35	4.48	4.50	4.44
query36	0.68	0.49	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.78 s
Total hot run time: 29.63 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 54.13% (14681/27124)
Line Coverage 43.00% (127842/297334)
Region Coverage 41.84% (65459/156435)
Branch Coverage 36.44% (32999/90552)

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.21% (14702/26630)
Line Coverage 44.61% (132428/296842)
Region Coverage 41.68% (76222/182858)
Branch Coverage 35.77% (36881/103106)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 27, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 9686997 into apache:master Apr 27, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants