Skip to content

[chore](nereids)Make the drop function info more readable #50426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

lsy3993
Copy link
Contributor

@lsy3993 lsy3993 commented Apr 25, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 25, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34178 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f8862397de3fce4ed8a6223770b5227e4447bcd3, data reload: false

------ Round 1 ----------------------------------
q1	26266	5078	5041	5041
q2	2074	290	190	190
q3	10391	1267	700	700
q4	10227	1031	518	518
q5	7544	2407	2354	2354
q6	194	163	134	134
q7	914	749	616	616
q8	9321	1296	1123	1123
q9	6787	5137	5117	5117
q10	6826	2305	1909	1909
q11	461	291	266	266
q12	349	352	219	219
q13	17773	3712	3135	3135
q14	230	223	218	218
q15	543	494	482	482
q16	440	455	409	409
q17	596	857	373	373
q18	7559	7280	7120	7120
q19	1220	951	552	552
q20	345	336	229	229
q21	3984	3427	2496	2496
q22	1048	1005	977	977
Total cold run time: 115092 ms
Total hot run time: 34178 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5136	5115	5060	5060
q2	246	329	233	233
q3	2228	2675	2322	2322
q4	1424	1812	1382	1382
q5	4606	4519	4357	4357
q6	208	161	127	127
q7	2017	1932	1788	1788
q8	2590	2496	2482	2482
q9	7184	7170	7147	7147
q10	2993	3178	2697	2697
q11	584	516	478	478
q12	689	791	602	602
q13	3532	3958	3277	3277
q14	289	303	289	289
q15	509	481	467	467
q16	461	510	467	467
q17	1203	1567	1424	1424
q18	7652	7529	7396	7396
q19	811	841	1085	841
q20	2027	2094	1892	1892
q21	5418	4673	4628	4628
q22	1052	1036	1014	1014
Total cold run time: 52859 ms
Total hot run time: 50370 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186111 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f8862397de3fce4ed8a6223770b5227e4447bcd3, data reload: false

query1	1005	456	502	456
query2	6556	1890	1900	1890
query3	6740	223	211	211
query4	26731	23956	23062	23062
query5	4358	615	450	450
query6	308	206	179	179
query7	4614	486	272	272
query8	284	238	229	229
query9	8619	2539	2563	2539
query10	465	322	268	268
query11	15536	15081	14972	14972
query12	158	115	110	110
query13	1662	514	388	388
query14	8846	6244	6203	6203
query15	211	179	166	166
query16	7198	631	474	474
query17	1191	752	547	547
query18	1961	393	319	319
query19	191	182	164	164
query20	111	115	117	115
query21	217	119	106	106
query22	4187	4264	4063	4063
query23	33883	32889	33049	32889
query24	8460	2401	2388	2388
query25	540	449	385	385
query26	1235	272	150	150
query27	2760	500	335	335
query28	4329	2125	2098	2098
query29	758	552	452	452
query30	280	218	190	190
query31	919	866	765	765
query32	71	67	63	63
query33	553	363	299	299
query34	807	860	510	510
query35	772	824	721	721
query36	977	1006	926	926
query37	112	103	80	80
query38	4203	4106	4149	4106
query39	1446	1414	1397	1397
query40	212	123	107	107
query41	60	57	53	53
query42	122	106	109	106
query43	507	516	489	489
query44	1301	801	791	791
query45	179	173	172	172
query46	825	1027	622	622
query47	1731	1762	1726	1726
query48	383	410	299	299
query49	783	494	428	428
query50	663	700	398	398
query51	4133	4081	4056	4056
query52	116	113	101	101
query53	231	257	191	191
query54	585	592	516	516
query55	83	82	83	82
query56	317	319	296	296
query57	1150	1191	1068	1068
query58	284	293	267	267
query59	2795	2738	2785	2738
query60	333	332	322	322
query61	154	148	152	148
query62	830	749	688	688
query63	229	185	192	185
query64	4332	1007	678	678
query65	4333	4216	4255	4216
query66	1139	413	310	310
query67	15574	15467	15302	15302
query68	7758	885	516	516
query69	455	297	260	260
query70	1258	1124	1144	1124
query71	463	320	299	299
query72	5613	4818	4852	4818
query73	695	652	340	340
query74	9118	9095	8801	8801
query75	3771	3257	2684	2684
query76	3642	1188	751	751
query77	777	389	283	283
query78	10013	9898	9350	9350
query79	2379	809	561	561
query80	651	501	450	450
query81	502	280	225	225
query82	463	131	100	100
query83	253	261	229	229
query84	247	109	89	89
query85	796	360	315	315
query86	385	299	288	288
query87	4483	4487	4378	4378
query88	3826	2252	2227	2227
query89	390	317	281	281
query90	1822	210	213	210
query91	160	140	111	111
query92	74	63	59	59
query93	1942	928	575	575
query94	680	384	297	297
query95	372	294	281	281
query96	490	567	280	280
query97	3140	3236	3153	3153
query98	239	212	211	211
query99	1387	1382	1273	1273
Total cold run time: 274882 ms
Total hot run time: 186111 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.51 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f8862397de3fce4ed8a6223770b5227e4447bcd3, data reload: false

query1	0.03	0.04	0.03
query2	0.13	0.10	0.11
query3	0.25	0.20	0.19
query4	1.59	0.20	0.19
query5	0.59	0.59	0.59
query6	1.19	0.73	0.72
query7	0.03	0.01	0.02
query8	0.05	0.03	0.04
query9	0.59	0.53	0.51
query10	0.57	0.57	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.61	0.60	0.59
query14	1.16	1.17	1.20
query15	0.88	0.85	0.86
query16	0.38	0.38	0.37
query17	0.99	1.01	1.05
query18	0.22	0.20	0.19
query19	1.94	1.80	1.79
query20	0.02	0.01	0.02
query21	15.40	0.88	0.55
query22	0.77	1.24	0.75
query23	14.76	1.37	0.62
query24	6.84	1.44	0.75
query25	0.47	0.12	0.09
query26	0.73	0.17	0.13
query27	0.05	0.05	0.04
query28	9.25	0.86	0.42
query29	12.57	3.87	3.30
query30	0.26	0.09	0.06
query31	2.82	0.59	0.38
query32	3.25	0.55	0.47
query33	3.07	3.02	3.07
query34	15.79	5.18	4.48
query35	4.59	4.54	4.54
query36	0.68	0.50	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.33 s
Total hot run time: 29.51 s

@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 25, 2025

run p0

1 similar comment
@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 26, 2025

run p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 26, 2025

run cloud_p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 27, 2025

run p0

3 similar comments
@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 27, 2025

run p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 27, 2025

run p0

@lsy3993
Copy link
Contributor Author

lsy3993 commented Apr 27, 2025

run p0

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 28, 2025
Copy link
Contributor

PR approved by anyone and no changes requested.

@lsy3993 lsy3993 changed the title [chore]Make the drop function info more readable. [chore]Make the drop function info more readable Apr 28, 2025
@starocean999 starocean999 changed the title [chore]Make the drop function info more readable [chore](nereids)Make the drop function info more readable Apr 28, 2025
@starocean999 starocean999 merged commit 6c3c34b into apache:master Apr 28, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants