-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[opt](nereids) support prune partitions by specified tablet ids #50424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](nereids) support prune partitions by specified tablet ids #50424
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
63365f6
to
692c422
Compare
run buildall |
run buildall |
TPC-H: Total hot run time: 33747 ms
|
TPC-DS: Total hot run time: 191738 ms
|
ClickBench: Total hot run time: 28.6 s
|
run buildall |
run buildall |
run buildall |
TPC-H: Total hot run time: 33886 ms
|
TPC-DS: Total hot run time: 192873 ms
|
ClickBench: Total hot run time: 29.65 s
|
run buildall |
TPC-H: Total hot run time: 34298 ms
|
TPC-DS: Total hot run time: 192182 ms
|
ClickBench: Total hot run time: 29.01 s
|
run buildall |
TPC-H: Total hot run time: 33888 ms
|
TPC-DS: Total hot run time: 184335 ms
|
ClickBench: Total hot run time: 29.37 s
|
run buildall |
TPC-H: Total hot run time: 33637 ms
|
TPC-DS: Total hot run time: 191569 ms
|
ClickBench: Total hot run time: 28.8 s
|
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PruneOlapScanPartition.java
Outdated
Show resolved
Hide resolved
if (!selectedPartitions.isEmpty() && !selectedPartitions.contains(partition.getId())) { | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove local variable selectedPartitions and
if (!selectedPartitions.isEmpty() && !selectedPartitions.contains(partition.getId())) { | |
continue; | |
} | |
if (prunedPartitionsByFilters != null && !prunedPartitionsByFilters.contains(partition.getId()))) { | |
continue; | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of prunedPartitionsByFilters
is List
. The function contains()
may cost too much if the list's length is high.
…e/PruneOlapScanPartition.java Co-authored-by: morrySnow <morrysnow@126.com>
PR approved by at least one committer and no changes requested. |
run buildall |
TPC-H: Total hot run time: 33431 ms
|
TPC-DS: Total hot run time: 191643 ms
|
ClickBench: Total hot run time: 29.42 s
|
What problem does this PR solve?
Issue Number: close #50255
support prune partitions by specified tablet ids
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)