-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[fix](load) disable fetching meta request to disable_load or decommissioned BE node #50421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 33927 ms
|
TPC-DS: Total hot run time: 192422 ms
|
ClickBench: Total hot run time: 30.09 s
|
35eb89b
to
3fb0192
Compare
run buildall |
TPC-H: Total hot run time: 33839 ms
|
TPC-DS: Total hot run time: 185801 ms
|
ClickBench: Total hot run time: 29.62 s
|
3fb0192
to
0c800c5
Compare
run buildall |
0c800c5
to
9e74f3e
Compare
run buildall |
9e74f3e
to
f81c327
Compare
run buildall |
TPC-H: Total hot run time: 33921 ms
|
TPC-DS: Total hot run time: 186224 ms
|
ClickBench: Total hot run time: 28.89 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f81c327
to
be2980d
Compare
be2980d
to
9593487
Compare
run buildall |
TPC-H: Total hot run time: 33946 ms
|
TPC-DS: Total hot run time: 185849 ms
|
ClickBench: Total hot run time: 30.42 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…sioned BE node (#50421) If user disable load in a certain node:`ALTER SYSTEM MODIFY BACKEND "xxx" SET ("disable_load" = "true");`, planner will not select this node to load but fetch meta request still select the node. The pr disable fetch meta request when set disable_load.
What problem does this PR solve?
If user disable load in a certain node:
ALTER SYSTEM MODIFY BACKEND "xxx" SET ("disable_load" = "true");
, planner will not select this node to load but fetch meta request still select the node. The pr disable fetch meta request when set disable_load.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)