Skip to content

[fix](load) disable fetching meta request to disable_load or decommissioned BE node #50421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

sollhui
Copy link
Contributor

@sollhui sollhui commented Apr 25, 2025

What problem does this PR solve?

If user disable load in a certain node:ALTER SYSTEM MODIFY BACKEND "xxx" SET ("disable_load" = "true");, planner will not select this node to load but fetch meta request still select the node. The pr disable fetch meta request when set disable_load.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@sollhui
Copy link
Contributor Author

sollhui commented Apr 25, 2025

run buildall

dataroaring
dataroaring previously approved these changes Apr 25, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring added the usercase Important user case type label label Apr 25, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 33927 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 35eb89b6d4043c7c8d74da02aae3da9b679ee86c, data reload: false

------ Round 1 ----------------------------------
q1	25975	5073	5053	5053
q2	2069	271	180	180
q3	10404	1240	693	693
q4	10222	1016	549	549
q5	7536	2377	2267	2267
q6	186	163	136	136
q7	914	752	615	615
q8	9320	1279	1143	1143
q9	6760	5002	5041	5002
q10	6806	2287	1881	1881
q11	470	299	284	284
q12	352	354	227	227
q13	17783	3705	3084	3084
q14	225	226	223	223
q15	549	475	489	475
q16	456	453	411	411
q17	595	843	375	375
q18	7414	7047	7020	7020
q19	1407	954	565	565
q20	336	336	235	235
q21	4152	3428	2546	2546
q22	1060	1032	963	963
Total cold run time: 114991 ms
Total hot run time: 33927 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5106	5107	5091	5091
q2	237	327	233	233
q3	2161	2590	2278	2278
q4	1403	1762	1365	1365
q5	4404	4386	4372	4372
q6	216	164	134	134
q7	2054	1955	1754	1754
q8	2582	2728	2545	2545
q9	7340	7148	6881	6881
q10	3051	3175	2745	2745
q11	573	519	506	506
q12	666	770	629	629
q13	3490	3861	3249	3249
q14	321	308	284	284
q15	540	506	482	482
q16	482	506	483	483
q17	1157	1551	1430	1430
q18	7736	7555	7431	7431
q19	843	871	932	871
q20	1929	1928	1839	1839
q21	5159	4727	4813	4727
q22	1114	1068	1016	1016
Total cold run time: 52564 ms
Total hot run time: 50345 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192422 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 35eb89b6d4043c7c8d74da02aae3da9b679ee86c, data reload: false

query1	1374	1091	1042	1042
query2	6212	1932	1912	1912
query3	10990	4526	4396	4396
query4	51947	25954	23087	23087
query5	5213	498	450	450
query6	317	201	196	196
query7	4862	492	294	294
query8	307	250	232	232
query9	5577	2610	2595	2595
query10	434	330	275	275
query11	15068	15033	14796	14796
query12	163	110	105	105
query13	1050	502	406	406
query14	9987	6359	6453	6359
query15	211	194	163	163
query16	7047	682	496	496
query17	1084	759	586	586
query18	1576	404	319	319
query19	188	187	164	164
query20	136	132	123	123
query21	204	129	112	112
query22	4413	4486	4181	4181
query23	34100	33408	33321	33321
query24	6560	2372	2437	2372
query25	447	479	407	407
query26	678	271	148	148
query27	2297	502	344	344
query28	3192	2171	2173	2171
query29	604	594	454	454
query30	276	227	187	187
query31	860	864	806	806
query32	78	70	76	70
query33	516	363	314	314
query34	761	849	529	529
query35	782	840	758	758
query36	972	1035	922	922
query37	112	100	81	81
query38	4227	4190	4208	4190
query39	1497	1429	1440	1429
query40	219	126	109	109
query41	56	57	51	51
query42	123	107	111	107
query43	520	525	513	513
query44	1330	858	863	858
query45	182	173	165	165
query46	855	1029	664	664
query47	1806	1890	1810	1810
query48	399	429	304	304
query49	681	495	414	414
query50	649	685	412	412
query51	4184	4246	4148	4148
query52	114	111	103	103
query53	229	259	193	193
query54	572	579	512	512
query55	82	76	79	76
query56	324	310	285	285
query57	1156	1215	1111	1111
query58	275	263	268	263
query59	2828	2878	2782	2782
query60	355	338	328	328
query61	149	156	148	148
query62	741	733	687	687
query63	232	201	202	201
query64	1618	1147	777	777
query65	4445	4344	4381	4344
query66	799	408	314	314
query67	15771	15623	15277	15277
query68	7221	886	510	510
query69	542	311	262	262
query70	1217	1134	1077	1077
query71	502	315	310	310
query72	5855	4901	4898	4898
query73	1474	675	353	353
query74	9210	9206	8691	8691
query75	3824	3201	2716	2716
query76	4205	1194	754	754
query77	627	363	283	283
query78	9961	10115	9259	9259
query79	2169	799	558	558
query80	584	503	443	443
query81	483	260	230	230
query82	451	129	99	99
query83	257	261	292	261
query84	296	103	82	82
query85	795	356	323	323
query86	387	301	314	301
query87	4456	4404	4339	4339
query88	3753	2247	2232	2232
query89	405	312	277	277
query90	1814	217	220	217
query91	138	141	109	109
query92	68	62	54	54
query93	1744	942	579	579
query94	662	419	306	306
query95	368	301	283	283
query96	477	559	273	273
query97	3148	3251	3128	3128
query98	307	208	207	207
query99	1416	1396	1260	1260
Total cold run time: 295829 ms
Total hot run time: 192422 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.09 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 35eb89b6d4043c7c8d74da02aae3da9b679ee86c, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.20
query4	1.59	0.19	0.19
query5	0.62	0.60	0.62
query6	1.20	0.72	0.72
query7	0.03	0.02	0.01
query8	0.04	0.03	0.04
query9	0.58	0.53	0.51
query10	0.58	0.56	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	1.16	1.16	1.19
query15	0.89	0.87	0.87
query16	0.38	0.43	0.38
query17	1.03	1.04	1.01
query18	0.21	0.19	0.19
query19	1.88	1.77	1.80
query20	0.01	0.01	0.02
query21	15.39	0.92	0.54
query22	0.75	1.13	0.69
query23	15.00	1.39	0.60
query24	7.05	2.08	1.42
query25	0.51	0.26	0.13
query26	0.65	0.16	0.13
query27	0.05	0.05	0.05
query28	9.58	0.79	0.45
query29	12.54	4.00	3.28
query30	0.26	0.09	0.08
query31	2.81	0.60	0.40
query32	3.22	0.56	0.46
query33	3.05	3.02	3.04
query34	15.78	5.12	4.41
query35	4.49	4.47	4.50
query36	0.65	0.51	0.50
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.07	0.03	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.77 s
Total hot run time: 30.09 s

@sollhui
Copy link
Contributor Author

sollhui commented Apr 25, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 25, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 33839 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3fb01924269e72e8207ce5dcb79bfb89ca1ff4e8, data reload: false

------ Round 1 ----------------------------------
q1	26016	5016	4968	4968
q2	2066	285	177	177
q3	10400	1262	696	696
q4	10227	1011	514	514
q5	7556	2331	2332	2331
q6	185	166	131	131
q7	908	735	650	650
q8	9338	1282	1057	1057
q9	6942	5103	5172	5103
q10	6805	2302	1874	1874
q11	467	287	267	267
q12	340	349	223	223
q13	17760	3710	3099	3099
q14	223	237	204	204
q15	536	483	481	481
q16	447	442	394	394
q17	596	854	379	379
q18	7467	7229	7110	7110
q19	1211	946	528	528
q20	353	342	230	230
q21	4002	3339	2446	2446
q22	1030	983	977	977
Total cold run time: 114875 ms
Total hot run time: 33839 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5037	5005	5026	5005
q2	233	321	235	235
q3	2195	2691	2275	2275
q4	1415	1802	1320	1320
q5	4508	4505	4380	4380
q6	207	164	126	126
q7	2005	1960	1712	1712
q8	2608	2474	2455	2455
q9	7130	7038	7067	7038
q10	3002	3153	2707	2707
q11	553	519	486	486
q12	672	794	617	617
q13	3478	3854	3332	3332
q14	285	291	265	265
q15	518	486	472	472
q16	470	497	451	451
q17	1126	1526	1417	1417
q18	7699	7562	7407	7407
q19	790	750	828	750
q20	1993	2049	1881	1881
q21	5247	4678	4603	4603
q22	1040	1011	982	982
Total cold run time: 52211 ms
Total hot run time: 49916 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185801 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3fb01924269e72e8207ce5dcb79bfb89ca1ff4e8, data reload: false

query1	1005	459	498	459
query2	6562	1913	1873	1873
query3	6747	230	218	218
query4	26560	23535	22954	22954
query5	4379	604	471	471
query6	299	215	176	176
query7	4612	490	277	277
query8	288	235	222	222
query9	8609	2541	2563	2541
query10	493	315	270	270
query11	15793	15073	15028	15028
query12	155	110	103	103
query13	1644	496	404	404
query14	8880	6117	6126	6117
query15	194	209	171	171
query16	7152	644	496	496
query17	1217	728	586	586
query18	1985	404	307	307
query19	188	189	156	156
query20	125	116	117	116
query21	214	129	113	113
query22	4004	4129	4007	4007
query23	34118	32919	33088	32919
query24	8431	2385	2410	2385
query25	562	484	416	416
query26	1231	270	154	154
query27	2753	497	341	341
query28	4340	2113	2106	2106
query29	787	573	485	485
query30	282	213	186	186
query31	915	867	752	752
query32	74	64	63	63
query33	556	358	297	297
query34	797	841	514	514
query35	792	792	731	731
query36	966	991	985	985
query37	115	105	76	76
query38	4137	4069	4055	4055
query39	1427	1417	1395	1395
query40	213	116	106	106
query41	59	59	55	55
query42	116	104	102	102
query43	502	512	483	483
query44	1281	804	793	793
query45	174	178	170	170
query46	816	1017	613	613
query47	1728	1806	1739	1739
query48	377	406	291	291
query49	756	520	420	420
query50	642	672	384	384
query51	4197	4266	4111	4111
query52	112	104	99	99
query53	222	260	187	187
query54	578	575	494	494
query55	85	84	84	84
query56	305	278	273	273
query57	1136	1154	1113	1113
query58	264	250	247	247
query59	2804	2745	2678	2678
query60	330	325	295	295
query61	131	141	134	134
query62	775	816	670	670
query63	225	187	186	186
query64	4381	993	665	665
query65	4286	4310	4210	4210
query66	1131	419	326	326
query67	15733	15452	15307	15307
query68	8079	883	522	522
query69	473	298	267	267
query70	1225	1065	1088	1065
query71	458	303	291	291
query72	5587	4713	4892	4713
query73	752	673	346	346
query74	8826	9351	8854	8854
query75	3765	3196	2705	2705
query76	3619	1185	744	744
query77	783	379	283	283
query78	10225	10125	9301	9301
query79	1999	799	557	557
query80	723	546	442	442
query81	471	256	221	221
query82	450	126	101	101
query83	279	259	233	233
query84	303	110	90	90
query85	783	356	308	308
query86	338	321	295	295
query87	4352	4395	4342	4342
query88	3075	2214	2207	2207
query89	378	331	300	300
query90	1929	215	209	209
query91	140	143	125	125
query92	82	64	54	54
query93	1326	950	579	579
query94	668	406	308	308
query95	383	290	281	281
query96	484	555	277	277
query97	3155	3254	3126	3126
query98	227	211	203	203
query99	1419	1396	1292	1292
Total cold run time: 273503 ms
Total hot run time: 185801 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.62 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3fb01924269e72e8207ce5dcb79bfb89ca1ff4e8, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.27	0.19	0.19
query4	1.59	0.19	0.19
query5	0.59	0.60	0.61
query6	1.20	0.72	0.73
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.57	0.53	0.50
query10	0.57	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.59
query14	1.14	1.15	1.17
query15	0.87	0.86	0.84
query16	0.38	0.38	0.40
query17	1.00	1.01	1.00
query18	0.21	0.19	0.20
query19	1.84	1.78	1.78
query20	0.01	0.01	0.00
query21	15.41	0.87	0.54
query22	0.76	1.19	0.68
query23	14.91	1.39	0.67
query24	7.02	1.58	0.93
query25	0.53	0.28	0.06
query26	0.60	0.16	0.13
query27	0.06	0.05	0.04
query28	10.01	0.84	0.44
query29	12.52	4.02	3.31
query30	0.26	0.09	0.06
query31	2.84	0.60	0.39
query32	3.23	0.55	0.47
query33	3.10	3.05	3.05
query34	15.70	5.08	4.48
query35	4.48	4.50	4.48
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.96 s
Total hot run time: 29.62 s

@sollhui
Copy link
Contributor Author

sollhui commented Apr 26, 2025

run buildall

@sollhui
Copy link
Contributor Author

sollhui commented Apr 26, 2025

run buildall

@sollhui
Copy link
Contributor Author

sollhui commented Apr 26, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33921 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f81c327c1e356ebc72bda71cbefc41550bd82e32, data reload: false

------ Round 1 ----------------------------------
q1	26011	5144	5073	5073
q2	2061	278	182	182
q3	10393	1232	690	690
q4	10247	1012	526	526
q5	7570	2371	2414	2371
q6	191	166	134	134
q7	926	737	641	641
q8	9345	1324	1057	1057
q9	6774	5142	5051	5051
q10	6826	2308	1871	1871
q11	478	291	285	285
q12	346	352	231	231
q13	17801	3693	3049	3049
q14	233	221	224	221
q15	510	481	490	481
q16	444	447	397	397
q17	578	875	386	386
q18	7767	7292	7094	7094
q19	1202	954	564	564
q20	349	331	223	223
q21	3934	3359	2428	2428
q22	1084	1024	966	966
Total cold run time: 115070 ms
Total hot run time: 33921 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5196	5121	5142	5121
q2	241	323	232	232
q3	2204	2665	2305	2305
q4	1428	1807	1393	1393
q5	4589	4446	4388	4388
q6	215	167	130	130
q7	2002	1898	1750	1750
q8	2652	2503	2497	2497
q9	7249	7087	7226	7087
q10	2981	3221	2767	2767
q11	570	510	485	485
q12	707	782	644	644
q13	3514	3870	3298	3298
q14	311	299	278	278
q15	519	476	473	473
q16	458	503	470	470
q17	1187	1555	1372	1372
q18	7705	7587	7242	7242
q19	829	944	1189	944
q20	2002	2000	1896	1896
q21	5193	4798	4615	4615
q22	1059	1073	1025	1025
Total cold run time: 52811 ms
Total hot run time: 50412 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186224 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f81c327c1e356ebc72bda71cbefc41550bd82e32, data reload: false

query1	1010	480	527	480
query2	6574	1901	1885	1885
query3	6750	218	216	216
query4	26847	23610	22999	22999
query5	4296	641	448	448
query6	299	211	191	191
query7	4632	482	294	294
query8	295	244	233	233
query9	8613	2567	2593	2567
query10	441	316	262	262
query11	15246	15183	15442	15183
query12	157	109	103	103
query13	1657	534	412	412
query14	9273	6239	6160	6160
query15	208	186	168	168
query16	7199	647	494	494
query17	1195	715	557	557
query18	1975	386	296	296
query19	184	190	162	162
query20	118	113	120	113
query21	210	122	106	106
query22	4188	4268	4122	4122
query23	33870	33056	32964	32964
query24	8489	2418	2383	2383
query25	535	469	372	372
query26	1237	263	163	163
query27	2776	492	327	327
query28	4358	2102	2099	2099
query29	816	549	428	428
query30	280	227	189	189
query31	930	865	734	734
query32	71	70	61	61
query33	564	365	319	319
query34	788	839	503	503
query35	798	793	726	726
query36	953	991	908	908
query37	113	96	75	75
query38	4136	4133	4039	4039
query39	1482	1396	1371	1371
query40	207	119	105	105
query41	57	54	52	52
query42	119	107	108	107
query43	521	512	481	481
query44	1278	803	802	802
query45	177	177	177	177
query46	836	1021	620	620
query47	1762	1790	1716	1716
query48	400	413	324	324
query49	782	494	413	413
query50	643	674	397	397
query51	4129	4059	4046	4046
query52	110	112	99	99
query53	222	254	182	182
query54	589	572	508	508
query55	83	78	80	78
query56	325	304	282	282
query57	1143	1134	1106	1106
query58	265	252	255	252
query59	2682	2731	2705	2705
query60	318	319	303	303
query61	132	128	127	127
query62	830	704	699	699
query63	231	190	188	188
query64	4374	1006	668	668
query65	4300	4262	4265	4262
query66	1147	408	365	365
query67	15912	15518	15292	15292
query68	5474	890	521	521
query69	481	306	262	262
query70	1143	1071	1121	1071
query71	395	330	322	322
query72	5604	4655	4676	4655
query73	641	605	345	345
query74	9099	9088	8885	8885
query75	3162	3219	2706	2706
query76	3181	1183	774	774
query77	485	402	294	294
query78	9837	10137	9318	9318
query79	1837	800	567	567
query80	642	550	492	492
query81	506	261	235	235
query82	185	129	100	100
query83	270	273	255	255
query84	255	108	100	100
query85	819	420	379	379
query86	376	298	297	297
query87	4381	4455	4202	4202
query88	2800	2247	2331	2247
query89	373	315	280	280
query90	1932	220	219	219
query91	140	141	117	117
query92	78	62	54	54
query93	1568	939	585	585
query94	674	417	306	306
query95	372	296	281	281
query96	482	572	280	280
query97	3137	3242	3113	3113
query98	230	210	239	210
query99	1327	1385	1284	1284
Total cold run time: 269023 ms
Total hot run time: 186224 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.89 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f81c327c1e356ebc72bda71cbefc41550bd82e32, data reload: false

query1	0.04	0.03	0.04
query2	0.13	0.11	0.12
query3	0.25	0.20	0.19
query4	1.60	0.19	0.20
query5	0.59	0.60	0.57
query6	1.19	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.56	0.54	0.50
query10	0.57	0.59	0.57
query11	0.15	0.10	0.10
query12	0.14	0.12	0.11
query13	0.61	0.59	0.59
query14	1.14	1.17	1.18
query15	0.87	0.84	0.84
query16	0.39	0.38	0.38
query17	1.04	1.04	1.01
query18	0.20	0.20	0.19
query19	1.81	1.79	1.82
query20	0.01	0.01	0.01
query21	15.41	0.92	0.55
query22	0.76	1.23	0.64
query23	14.93	1.40	0.61
query24	7.05	1.34	0.29
query25	0.33	0.37	0.08
query26	0.59	0.16	0.15
query27	0.05	0.05	0.05
query28	9.20	0.88	0.45
query29	12.53	3.90	3.29
query30	0.25	0.09	0.06
query31	2.83	0.59	0.39
query32	3.22	0.54	0.46
query33	3.02	3.04	2.99
query34	16.02	5.13	4.47
query35	4.51	4.55	4.52
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.03	0.02
query40	0.17	0.13	0.12
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.18 s
Total hot run time: 28.89 s

dataroaring
dataroaring previously approved these changes Apr 27, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 27, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

liaoxin01
liaoxin01 previously approved these changes Apr 27, 2025
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sollhui sollhui dismissed stale reviews from liaoxin01 and dataroaring via be2980d April 27, 2025 10:01
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 27, 2025
@sollhui sollhui changed the title [fix](load) disable fetch meta request when set disable_load [fix](load) disable fetch meta request to disable_load or decommissioned BE node Apr 27, 2025
@sollhui
Copy link
Contributor Author

sollhui commented Apr 27, 2025

run buildall

@sollhui sollhui changed the title [fix](load) disable fetch meta request to disable_load or decommissioned BE node [fix](load) disable fetching meta request to disable_load or decommissioned BE node Apr 27, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 33946 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 95934875516cb705bbd6375b74ae7f2dcf7da5a8, data reload: false

------ Round 1 ----------------------------------
q1	26092	5041	4997	4997
q2	2083	278	182	182
q3	10391	1204	700	700
q4	10227	971	522	522
q5	7551	2297	2355	2297
q6	183	162	136	136
q7	893	747	615	615
q8	9304	1288	1070	1070
q9	6781	5098	5113	5098
q10	6797	2289	1878	1878
q11	474	281	267	267
q12	343	345	209	209
q13	17787	3671	3133	3133
q14	228	228	208	208
q15	539	492	489	489
q16	450	448	406	406
q17	590	848	377	377
q18	7602	7336	7180	7180
q19	1207	952	550	550
q20	339	330	224	224
q21	3879	2686	2441	2441
q22	1067	1050	967	967
Total cold run time: 114807 ms
Total hot run time: 33946 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5134	5092	5085	5085
q2	237	326	229	229
q3	2139	2621	2267	2267
q4	1350	1780	1417	1417
q5	4409	4425	4400	4400
q6	224	175	126	126
q7	2014	1895	1736	1736
q8	2626	2547	2514	2514
q9	7319	7113	7165	7113
q10	2985	3173	2742	2742
q11	562	537	508	508
q12	645	780	575	575
q13	3510	3906	3346	3346
q14	296	304	295	295
q15	520	484	467	467
q16	456	498	464	464
q17	1155	1483	1434	1434
q18	7608	7465	7353	7353
q19	782	769	815	769
q20	1978	2101	1857	1857
q21	5152	4625	4519	4519
q22	1052	1033	982	982
Total cold run time: 52153 ms
Total hot run time: 50198 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185849 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 95934875516cb705bbd6375b74ae7f2dcf7da5a8, data reload: false

query1	1014	482	486	482
query2	6586	1891	1935	1891
query3	6741	226	216	216
query4	26092	23799	23405	23405
query5	4301	616	460	460
query6	316	207	205	205
query7	4616	489	294	294
query8	287	227	231	227
query9	8620	2563	2595	2563
query10	471	326	262	262
query11	15655	15172	14829	14829
query12	169	108	103	103
query13	1659	517	401	401
query14	9734	6262	6271	6262
query15	205	198	175	175
query16	7325	644	481	481
query17	1192	727	577	577
query18	1996	407	332	332
query19	195	187	172	172
query20	120	120	121	120
query21	207	126	111	111
query22	4044	4139	3999	3999
query23	33890	32995	32950	32950
query24	8457	2390	2337	2337
query25	598	442	384	384
query26	1244	268	146	146
query27	2736	493	322	322
query28	4386	2102	2077	2077
query29	743	541	424	424
query30	285	209	189	189
query31	956	875	736	736
query32	133	62	64	62
query33	553	361	291	291
query34	797	829	506	506
query35	791	805	713	713
query36	923	997	891	891
query37	113	106	81	81
query38	4263	4155	4047	4047
query39	1433	1410	1401	1401
query40	216	122	106	106
query41	57	58	52	52
query42	118	103	109	103
query43	498	512	482	482
query44	1310	815	795	795
query45	173	175	170	170
query46	834	1014	620	620
query47	1750	1765	1717	1717
query48	362	415	292	292
query49	777	508	430	430
query50	627	676	399	399
query51	4071	4203	4106	4106
query52	105	103	94	94
query53	235	258	191	191
query54	569	566	491	491
query55	78	80	79	79
query56	301	304	279	279
query57	1122	1141	1094	1094
query58	255	254	251	251
query59	2539	2756	2638	2638
query60	335	317	297	297
query61	125	124	123	123
query62	794	727	701	701
query63	233	183	185	183
query64	4281	992	696	696
query65	4316	4231	4244	4231
query66	1144	449	315	315
query67	15829	15395	15090	15090
query68	8622	876	508	508
query69	457	319	259	259
query70	1180	1143	1099	1099
query71	460	316	292	292
query72	5266	4608	4616	4608
query73	697	564	337	337
query74	8852	9062	8964	8964
query75	4224	3195	2701	2701
query76	3707	1187	752	752
query77	785	357	275	275
query78	9900	10152	9331	9331
query79	1597	824	574	574
query80	604	509	441	441
query81	473	255	220	220
query82	180	130	97	97
query83	283	258	235	235
query84	294	100	86	86
query85	809	359	301	301
query86	344	289	308	289
query87	4436	4376	4308	4308
query88	2858	2270	2280	2270
query89	386	323	287	287
query90	2083	222	224	222
query91	142	138	112	112
query92	79	61	59	59
query93	1066	958	580	580
query94	667	405	303	303
query95	380	299	286	286
query96	496	568	277	277
query97	3144	3200	3111	3111
query98	223	207	204	204
query99	1467	1437	1312	1312
Total cold run time: 273061 ms
Total hot run time: 185849 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 95934875516cb705bbd6375b74ae7f2dcf7da5a8, data reload: false

query1	0.04	0.03	0.04
query2	0.14	0.11	0.11
query3	0.26	0.19	0.19
query4	1.59	0.20	0.19
query5	0.59	0.58	0.58
query6	1.18	0.71	0.71
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.52	0.50
query10	0.58	0.58	0.56
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.60	0.60
query14	1.17	1.17	1.20
query15	0.88	0.86	0.85
query16	0.38	0.37	0.39
query17	1.04	1.04	1.04
query18	0.20	0.19	0.20
query19	1.89	1.83	1.75
query20	0.01	0.01	0.02
query21	15.42	0.91	0.56
query22	0.76	1.31	0.88
query23	14.69	1.38	0.64
query24	6.76	1.48	1.46
query25	0.47	0.20	0.12
query26	0.74	0.16	0.13
query27	0.06	0.05	0.05
query28	8.97	0.83	0.43
query29	12.63	3.90	3.24
query30	0.26	0.08	0.06
query31	2.83	0.59	0.39
query32	3.23	0.56	0.46
query33	3.06	3.05	3.10
query34	15.76	5.15	4.49
query35	4.57	4.54	4.55
query36	0.66	0.50	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 102.87 s
Total hot run time: 30.42 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 27, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 5d5f1ff into apache:master Apr 28, 2025
26 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 28, 2025
…sioned BE node (#50421)

If user disable load in a certain node:`ALTER SYSTEM MODIFY BACKEND
"xxx" SET ("disable_load" = "true");`, planner will not select this node
to load but fetch meta request still select the node. The pr disable
fetch meta request when set disable_load.
dataroaring pushed a commit that referenced this pull request Apr 29, 2025
… or decommissioned BE node #50421 (#50516)

Cherry-picked from #50421

Co-authored-by: hui lai <laihui@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/2.1.x-conflict dev/3.0.6-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants