Skip to content

[chore](scan) Remove unused code in ScanLocalState #50407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Mryange
Copy link
Contributor

@Mryange Mryange commented Apr 25, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Apr 25, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33954 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c8326525cb53aaea65b373263e0c73c3a781e69, data reload: false

------ Round 1 ----------------------------------
q1	26329	5047	4968	4968
q2	2085	272	181	181
q3	10399	1254	719	719
q4	10233	1004	515	515
q5	7561	2422	2317	2317
q6	183	168	136	136
q7	918	745	603	603
q8	9345	1321	1016	1016
q9	7082	5088	5108	5088
q10	6801	2289	1879	1879
q11	482	281	270	270
q12	355	357	221	221
q13	17767	3652	3082	3082
q14	233	230	205	205
q15	535	506	481	481
q16	434	441	395	395
q17	583	853	371	371
q18	7764	7204	7176	7176
q19	1221	949	581	581
q20	336	332	232	232
q21	4330	3429	2539	2539
q22	1070	1016	979	979
Total cold run time: 116046 ms
Total hot run time: 33954 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5157	5102	5036	5036
q2	236	332	223	223
q3	2128	2678	2269	2269
q4	1435	1820	1416	1416
q5	4597	4436	4400	4400
q6	204	164	125	125
q7	1990	1892	1726	1726
q8	2575	2505	2505	2505
q9	7244	7076	7122	7076
q10	3007	3171	2746	2746
q11	562	514	485	485
q12	691	784	583	583
q13	3518	3898	3294	3294
q14	299	317	285	285
q15	526	494	473	473
q16	460	517	471	471
q17	1152	1581	1416	1416
q18	7729	7444	7577	7444
q19	785	831	1056	831
q20	2019	2008	1899	1899
q21	5270	4907	4606	4606
q22	1047	1045	978	978
Total cold run time: 52631 ms
Total hot run time: 50287 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185924 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c8326525cb53aaea65b373263e0c73c3a781e69, data reload: false

query1	1025	456	482	456
query2	6561	1862	1801	1801
query3	6748	218	218	218
query4	26657	23610	23424	23424
query5	4369	652	468	468
query6	295	214	195	195
query7	4623	482	292	292
query8	308	256	222	222
query9	8602	2564	2570	2564
query10	473	320	260	260
query11	15542	15134	14967	14967
query12	153	117	103	103
query13	1650	512	393	393
query14	8712	6282	6228	6228
query15	212	195	177	177
query16	7344	641	479	479
query17	1213	720	577	577
query18	1980	415	337	337
query19	194	190	161	161
query20	120	116	119	116
query21	213	126	112	112
query22	4165	4134	4068	4068
query23	33987	33049	33085	33049
query24	8480	2380	2405	2380
query25	579	474	444	444
query26	1240	267	152	152
query27	2757	498	332	332
query28	4337	2091	2087	2087
query29	771	558	423	423
query30	280	214	187	187
query31	941	840	773	773
query32	77	64	64	64
query33	546	380	319	319
query34	792	894	510	510
query35	795	811	764	764
query36	967	999	892	892
query37	106	97	78	78
query38	4146	4147	4138	4138
query39	1472	1413	1404	1404
query40	212	121	111	111
query41	58	55	53	53
query42	125	104	111	104
query43	500	503	473	473
query44	1270	804	777	777
query45	183	177	171	171
query46	816	1014	632	632
query47	1736	1808	1715	1715
query48	391	409	307	307
query49	778	516	431	431
query50	646	693	406	406
query51	4106	4112	4045	4045
query52	107	104	99	99
query53	223	263	185	185
query54	589	573	500	500
query55	84	80	81	80
query56	294	296	273	273
query57	1123	1141	1097	1097
query58	264	256	242	242
query59	2576	2648	2532	2532
query60	312	323	298	298
query61	130	129	127	127
query62	778	706	647	647
query63	230	190	200	190
query64	4394	1032	661	661
query65	4382	4289	4206	4206
query66	1187	403	342	342
query67	15645	15342	15255	15255
query68	8339	880	514	514
query69	478	307	265	265
query70	1240	1130	1078	1078
query71	518	316	295	295
query72	5626	4668	4571	4571
query73	699	567	347	347
query74	9053	9068	8809	8809
query75	4003	3223	2698	2698
query76	3748	1194	765	765
query77	790	377	300	300
query78	10237	10021	9230	9230
query79	2174	796	562	562
query80	585	504	447	447
query81	479	253	219	219
query82	485	128	95	95
query83	244	249	241	241
query84	253	105	85	85
query85	894	361	318	318
query86	389	302	290	290
query87	4352	4394	4309	4309
query88	3618	2172	2179	2172
query89	386	315	291	291
query90	1891	208	203	203
query91	140	157	179	157
query92	77	60	56	56
query93	1599	951	587	587
query94	673	403	310	310
query95	374	294	282	282
query96	472	563	273	273
query97	3161	3268	3118	3118
query98	238	206	204	204
query99	1443	1437	1260	1260
Total cold run time: 275229 ms
Total hot run time: 185924 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.08 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c8326525cb53aaea65b373263e0c73c3a781e69, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.18	0.20
query4	1.60	0.19	0.18
query5	0.58	0.58	0.59
query6	1.19	0.72	0.71
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.58	0.52	0.51
query10	0.56	0.57	0.57
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	1.20	1.19	1.17
query15	0.87	0.86	0.86
query16	0.39	0.39	0.38
query17	1.03	1.03	1.02
query18	0.22	0.20	0.20
query19	1.92	1.83	1.75
query20	0.01	0.01	0.01
query21	15.41	0.91	0.56
query22	0.77	1.22	0.67
query23	14.88	1.37	0.62
query24	6.90	1.90	0.31
query25	0.28	0.13	0.08
query26	0.56	0.17	0.15
query27	0.05	0.05	0.05
query28	9.21	0.88	0.45
query29	12.68	3.97	3.32
query30	0.25	0.09	0.06
query31	2.82	0.59	0.39
query32	3.21	0.55	0.47
query33	2.97	3.10	3.02
query34	15.70	5.13	4.50
query35	4.58	4.56	4.54
query36	0.65	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 102.93 s
Total hot run time: 29.08 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 92.75% (64/69) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.75% (14593/27150)
Line Coverage 42.57% (126647/297500)
Region Coverage 41.38% (64752/156486)
Branch Coverage 35.93% (32552/90596)

@hello-stephen
Copy link
Contributor

BE Regression P0 && UT Coverage Report

Increment line coverage 0.00% (0/69) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.15% (14703/26660)
Line Coverage 44.56% (132345/297011)
Region Coverage 41.67% (76202/182888)
Branch Coverage 35.75% (36871/103140)

@Mryange
Copy link
Contributor Author

Mryange commented Apr 26, 2025

run buildall

@Mryange Mryange closed this Apr 26, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 34549 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1c8326525cb53aaea65b373263e0c73c3a781e69, data reload: false

------ Round 1 ----------------------------------
q1	26257	5095	5298	5095
q2	2504	294	184	184
q3	11009	1269	704	704
q4	10230	1026	564	564
q5	7479	2478	2395	2395
q6	186	172	133	133
q7	917	760	651	651
q8	9396	1263	1125	1125
q9	8336	5280	5350	5280
q10	7178	2313	1888	1888
q11	500	284	269	269
q12	362	355	229	229
q13	20786	3757	3145	3145
q14	228	238	210	210
q15	609	478	488	478
q16	545	453	407	407
q17	603	845	392	392
q18	7540	7149	7194	7149
q19	1817	964	554	554
q20	331	332	227	227
q21	4086	3405	2474	2474
q22	1070	1036	996	996
Total cold run time: 121969 ms
Total hot run time: 34549 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5193	5058	5063	5058
q2	242	330	234	234
q3	2119	2705	2417	2417
q4	1509	1916	1558	1558
q5	4474	4374	4307	4307
q6	217	165	130	130
q7	1973	1919	1755	1755
q8	2612	2582	2582	2582
q9	7171	7266	7074	7074
q10	2961	3194	2755	2755
q11	564	506	503	503
q12	670	739	631	631
q13	3519	3936	3318	3318
q14	308	306	279	279
q15	519	495	482	482
q16	468	499	461	461
q17	1144	1535	1420	1420
q18	7845	7522	7381	7381
q19	766	773	840	773
q20	1911	2007	1854	1854
q21	5367	4728	4806	4728
q22	1101	1098	1032	1032
Total cold run time: 52653 ms
Total hot run time: 50732 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192810 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1c8326525cb53aaea65b373263e0c73c3a781e69, data reload: false

query1	1404	1065	1049	1049
query2	6183	1897	1869	1869
query3	11111	4474	4396	4396
query4	54006	24449	23396	23396
query5	5078	597	445	445
query6	356	192	231	192
query7	4867	505	310	310
query8	312	259	236	236
query9	5440	2541	2566	2541
query10	442	325	272	272
query11	15060	15285	14814	14814
query12	157	110	103	103
query13	1037	524	393	393
query14	10164	6308	6354	6308
query15	216	202	173	173
query16	7049	666	516	516
query17	1098	765	588	588
query18	1568	423	327	327
query19	202	202	177	177
query20	126	126	123	123
query21	208	128	111	111
query22	4559	4522	4390	4390
query23	34178	33495	33543	33495
query24	6576	2438	2439	2438
query25	464	448	391	391
query26	725	275	168	168
query27	2403	497	325	325
query28	3019	2133	2146	2133
query29	579	554	422	422
query30	278	220	184	184
query31	837	849	789	789
query32	78	60	59	59
query33	457	365	318	318
query34	957	868	513	513
query35	821	812	746	746
query36	961	1008	897	897
query37	116	104	85	85
query38	4168	4236	4235	4235
query39	1511	1437	1435	1435
query40	222	124	105	105
query41	59	52	54	52
query42	127	102	104	102
query43	523	509	473	473
query44	1298	823	805	805
query45	184	177	171	171
query46	846	1032	634	634
query47	1849	1889	1860	1860
query48	378	432	311	311
query49	686	503	417	417
query50	671	710	423	423
query51	4188	4283	4182	4182
query52	110	111	96	96
query53	223	252	180	180
query54	581	574	541	541
query55	83	84	84	84
query56	298	305	295	295
query57	1176	1187	1151	1151
query58	264	256	256	256
query59	2744	2811	2786	2786
query60	351	337	300	300
query61	140	128	127	127
query62	734	752	684	684
query63	222	188	192	188
query64	1960	1061	669	669
query65	4406	4344	4332	4332
query66	731	398	295	295
query67	16033	15871	15301	15301
query68	6748	879	520	520
query69	535	300	259	259
query70	1142	1083	1093	1083
query71	491	309	298	298
query72	5943	4939	5044	4939
query73	1532	731	343	343
query74	9118	8801	8760	8760
query75	4096	3236	2718	2718
query76	4198	1186	750	750
query77	758	361	280	280
query78	10068	10061	9286	9286
query79	2300	815	566	566
query80	578	494	445	445
query81	493	250	224	224
query82	457	128	97	97
query83	247	255	235	235
query84	303	101	82	82
query85	752	343	304	304
query86	359	303	306	303
query87	4331	4402	4251	4251
query88	3797	2236	2219	2219
query89	400	324	275	275
query90	1800	206	204	204
query91	141	142	106	106
query92	78	58	61	58
query93	1846	954	577	577
query94	656	416	295	295
query95	372	288	283	283
query96	488	570	273	273
query97	3129	3247	3105	3105
query98	241	206	206	206
query99	1371	1413	1284	1284
Total cold run time: 298626 ms
Total hot run time: 192810 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.79 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1c8326525cb53aaea65b373263e0c73c3a781e69, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.12
query3	0.25	0.20	0.20
query4	1.59	0.19	0.19
query5	0.59	0.59	0.60
query6	1.20	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.56	0.51	0.52
query10	0.57	0.57	0.57
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.60	0.60
query14	1.19	1.20	1.23
query15	0.86	0.87	0.87
query16	0.39	0.38	0.39
query17	1.05	1.02	1.04
query18	0.21	0.20	0.19
query19	1.86	1.85	1.76
query20	0.02	0.01	0.01
query21	15.40	0.88	0.54
query22	0.76	1.31	0.75
query23	14.75	1.40	0.61
query24	6.90	2.16	0.92
query25	0.53	0.14	0.16
query26	0.66	0.16	0.14
query27	0.05	0.06	0.04
query28	10.18	0.85	0.44
query29	12.56	3.92	3.26
query30	0.27	0.09	0.07
query31	2.82	0.57	0.38
query32	3.23	0.54	0.48
query33	3.03	3.14	3.01
query34	15.73	5.11	4.49
query35	4.56	4.57	4.51
query36	0.67	0.49	0.47
query37	0.09	0.07	0.06
query38	0.06	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.09 s
Total hot run time: 29.79 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 92.75% (64/69) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 54.13% (14682/27123)
Line Coverage 43.00% (127849/297311)
Region Coverage 41.86% (65474/156415)
Branch Coverage 36.45% (33005/90542)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants