Skip to content

[Bug] fix issue #439 #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 18, 2025
Merged

[Bug] fix issue #439 #440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e7d480f
[Bug] fix issue #439
ztonny Sep 11, 2025
1a49211
[Bug] fix issue #439
ztonny Sep 18, 2025
62c3ea7
[Bug] fix issue #439
ztonny Sep 18, 2025
53ce8e8
Revert "[Bug] fix issue #439"
ztonny Sep 18, 2025
39222de
Revert "[Bug] fix issue #439"
ztonny Sep 18, 2025
e495120
[Bug] fix issue #439
ztonny Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/common/utils/mysql/mysql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,7 @@ func (db *DB) GetBackendsByComputeGroupId(cgid string) ([]*Backend, error) {
return nil, err
}
if _, ok := m[COMPUTE_GROUP_ID]; !ok {
klog.Errorf("GetBackendsByComputeGroupId backends tag get compute_group_name failed, tag: %s, err: %s\n", be.Tag, err.Error())
return nil, err
return nil, fmt.Errorf("GetBackendsByComputeGroupId backends tag get compute_group_name failed, tag: %s, err: no compute_group_id field found", be.Tag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'klog.Errorf' needs to print the error log, here you need to keep using this method to print this error log

}

computegroupId := fmt.Sprintf("%s", m[COMPUTE_GROUP_ID])
Expand Down
2 changes: 1 addition & 1 deletion pkg/common/utils/resource/configmap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ func Test_ResolveConfigMpas(t *testing.T) {

m, err := ResolveConfigMaps(tests, dorisv1.Component_FE)
if err != nil || len(m) == 0 {
t.Errorf("resolve configmaps faild, len=%d, err=%s", len(m), err.Error())
t.Errorf("resolve configmaps faild, len=%d, err=%#v", len(m), err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try not to use %#v to print structure instances. This may cause err null pointer problems and require post-processing after checking for null.

}
}

Expand Down
5 changes: 2 additions & 3 deletions pkg/controller/sub_controller/disaggregated_cluster/computegroups/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ func (dcgs *DisaggregatedComputeGroupsController) ClearStatefulsetUnusedPVCs(ctx
var perr error
index, perr = strconv.ParseInt(sl[1], 10, 32)
if perr != nil {
klog.Errorf("DisaggregatedComputeGroupsController ClearStatefulsetUnusedPVCs namespace %s name %s index parse failed, err=%s", ddc.Namespace, pvcName, err.Error())
klog.Errorf("DisaggregatedComputeGroupsController ClearStatefulsetUnusedPVCs namespace %s name %s index parse failed, err=%s", ddc.Namespace, pvcName, perr.Error())
continue
}
if int32(index) >= replicas {
Expand Down Expand Up @@ -639,8 +639,7 @@ func(dcgs *DisaggregatedComputeGroupsController) recordComputeGroupIds(ddc *dv1.
return err
}
if _, ok := tags[mysql.COMPUTE_GROUP_ID]; !ok {
klog.Errorf("DisaggregatedComputeGroupsController recordComputeGroupIds backend tag get compute_group_name failed, tag: %s, err: %s", backend.Tag, err.Error())
return err
return fmt.Errorf("DisaggregatedComputeGroupsController recordComputeGroupIds backend tag get compute_group_name failed, tag: %s, err: no compute_group_id field found ", backend.Tag)
}

podName := strings.Split(backend.Host, ".")[0]
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/sub_controller/sub_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ func (d *SubDefaultController) CheckSharedPVC(ctx context.Context, dcr *dorisv1.
for _, claim := range dcr.Spec.SharedPersistentVolumeClaims {
pvc, err := k8s.GetPVC(ctx, d.K8sclient, claim.PersistentVolumeClaimName, dcr.Namespace)
if err != nil || pvc == nil {
errMessage := fmt.Sprintf("(PersistentVolumeClaim get failed name: %s, namespace: %s, err: %s), ", claim.PersistentVolumeClaimName, dcr.Namespace, err.Error())
errMessage := fmt.Sprintf("(PersistentVolumeClaim get failed name: %s, namespace: %s, err: %#v), ", claim.PersistentVolumeClaimName, dcr.Namespace, err)
klog.Errorf(errMessage)
d.K8srecorder.Event(dcr, string(EventWarning), string(CheckSharePVC), errMessage)
return
Expand Down Expand Up @@ -555,7 +555,7 @@ func (d *SubDefaultController) listAndDeletePersistentVolumeClaim(ctx context.Co

dorisPersistentVolumes, err := d.GetFinalPersistentVolumes(ctx, dcr, componentType)
if err != nil {
d.K8srecorder.Event(dcr, string(EventWarning), PVCExplainFailed, fmt.Sprintf("listAndDeletePersistentVolumeClaim %s GetFinalPersistentVolumes failed：%s", componentType, err.Error()))
d.K8srecorder.Event(dcr, string(EventWarning), PVCExplainFailed, fmt.Sprintf("listAndDeletePersistentVolumeClaim %s GetFinalPersistentVolumes failed: %s", componentType, err.Error()))
return err
}

Expand Down