Skip to content

Conversation

bluicezhen
Copy link
Contributor

Add support for pod annotations in Helm charts

What this PR does

This PR adds support for setting pod annotations through Helm values. While the CRD already supports pod annotations configuration, this functionality was missing in the Helm charts.

Changes

  • Added podAnnotations field in values.yaml to allow users to specify custom pod annotations
  • Updated the pod template in deployment to include the annotations
  • Added documentation and example usage in values.yaml

Example Usage

Users can now set pod annotations in their values.yaml:

This commit introduces the ability to define annotations for various components in the Doris Helm chart, including front-end (fe), back-end (be), compute node (cn), and broker specifications. Annotations can now be specified in the values.yaml file, enhancing customization options for pod and service configurations.
Copy link
Contributor

@catpineapple catpineapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your submission. There are some details that need to be adjusted, and then it can be merged.

@bluicezhen bluicezhen requested a review from catpineapple March 31, 2025 09:38
Copy link
Contributor

@catpineapple catpineapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catpineapple catpineapple merged commit 6f0c69c into apache:master Apr 21, 2025
1 check passed
@catpineapple catpineapple mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants