Skip to content

[improve](dcr) enable skip default SystemInit for be #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2025
Merged

[improve](dcr) enable skip default SystemInit for be #321

merged 5 commits into from
Jan 9, 2025

Conversation

catpineapple
Copy link
Contributor

@catpineapple catpineapple commented Dec 27, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@catpineapple catpineapple changed the title add skipSystemInit for be [improve](dcr) enable skip default SystemInit for be Dec 27, 2024
intelligentfu8
intelligentfu8 reviewed Jan 8, 2025
View reviewed changes
pkg/common/utils/resource/pod.go
return containers
}

func constructInitContainers(componentType v1.ComponentType, podSpec *corev1.PodSpec, si *v1.SystemInitialization) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip as a parameter, and dcr will not be needed. the if logic will be concise.
if !skip && (compoentType==v1.Component_be || component==v1.Componet_CN){

}

intelligentfu8
intelligentfu8 reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@intelligentfu8 intelligentfu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check

@intelligentfu8 intelligentfu8 merged commit 16d250a into apache:master Jan 9, 2025
1 check passed
@catpineapple catpineapple deleted the enable-skip-system-init branch January 24, 2025 03:14
@intelligentfu8 intelligentfu8 mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@intelligentfu8 intelligentfu8 intelligentfu8 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catpineapple @intelligentfu8