Skip to content

[fix](ddc) use service name and namespace as fe access address #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

[fix](ddc) use service name and namespace as fe access address #291

merged 2 commits into from
Nov 13, 2024

Conversation

catpineapple
Copy link
Contributor

@catpineapple catpineapple commented Nov 13, 2024 •
edited
Loading

What problem does this PR solve?

fe service for access append namespace.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

intelligentfu8
intelligentfu8 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@intelligentfu8 intelligentfu8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@intelligentfu8 intelligentfu8 merged commit 7d27da0 into apache:master Nov 13, 2024
1 check passed
@intelligentfu8 intelligentfu8 changed the title [fix](ddc)fix fe service access in diff namespace [fix](ddc) use service name and namespace as fe addresss Nov 13, 2024
@intelligentfu8 intelligentfu8 changed the title [fix](ddc) use service name and namespace as fe addresss [fix](ddc) use service name and namespace as fe access address Nov 13, 2024
@catpineapple catpineapple deleted the fix-service-access-in-different-ns branch November 13, 2024 09:32
@catpineapple catpineapple mentioned this pull request Nov 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@intelligentfu8 intelligentfu8 intelligentfu8 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@catpineapple @intelligentfu8