use iteration in set ops, wrap compressed sketch and unpack in iterator #644
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package org.apache.datasketches.theta; | ||
|
|
||
| import static org.apache.datasketches.theta.PreambleUtil.extractEntryBitsV4; | ||
| import static org.apache.datasketches.theta.PreambleUtil.extractNumEntriesBytesV4; | ||
| import static org.apache.datasketches.theta.PreambleUtil.extractPreLongs; | ||
| import static org.apache.datasketches.theta.PreambleUtil.extractSeedHash; | ||
| import static org.apache.datasketches.theta.PreambleUtil.extractThetaLongV4; | ||
| import static org.apache.datasketches.theta.PreambleUtil.wholeBytesToHoldBits; | ||
|
|
||
| import org.apache.datasketches.memory.Memory; | ||
| import org.apache.datasketches.memory.WritableMemory; | ||
| import org.apache.datasketches.thetacommon.ThetaUtil; | ||
|
|
||
| /** | ||
| * An off-heap (Direct), compact, compressed, read-only sketch. It is not empty, not a single item and ordered. | ||
| * | ||
| * <p>This sketch can only be associated with a Serialization Version 4 format binary image.</p> | ||
| * | ||
| * <p>This implementation uses data in a given Memory that is owned and managed by the caller. | ||
| * This Memory can be off-heap, which if managed properly will greatly reduce the need for | ||
| * the JVM to perform garbage collection.</p> | ||
| */ | ||
| class DirectCompactCompressedSketch extends DirectCompactSketch { | ||
| /** | ||
| * Construct this sketch with the given memory. | ||
| * @param mem Read-only Memory object with the order bit properly set. | ||
| */ | ||
| DirectCompactCompressedSketch(final Memory mem) { | ||
| super(mem); | ||
| } | ||
|
|
||
| /** | ||
| * Wraps the given Memory, which must be a SerVer 4 compressed CompactSketch image. | ||
| * Must check the validity of the Memory before calling. The order bit must be set properly. | ||
|
|
||
| * @param srcMem <a href="{@docRoot}/resources/dictionary.html#mem">See Memory</a> | ||
| * @param seedHash The update seedHash. | ||
| * <a href="{@docRoot}/resources/dictionary.html#seedHash">See Seed Hash</a>. | ||
| * @return this sketch | ||
| */ | ||
| static DirectCompactCompressedSketch wrapInstance(final Memory srcMem, final short seedHash) { | ||
| ThetaUtil.checkSeedHashes((short) extractSeedHash(srcMem), seedHash); | ||
| return new DirectCompactCompressedSketch(srcMem); | ||
| } | ||
|
|
||
| //Sketch Overrides | ||
|
|
||
| @Override | ||
| public CompactSketch compact(final boolean dstOrdered, final WritableMemory dstMem) { | ||
| if (dstMem != null) { | ||
| mem_.copyTo(0, dstMem, 0, getCurrentBytes()); | ||
| return new DirectCompactSketch(dstMem); | ||
| } | ||
| return CompactSketch.heapify(mem_); | ||
| } | ||
|
|
||
| @Override | ||
| public int getCurrentBytes() { | ||
| final int preLongs = extractPreLongs(mem_); | ||
| final int entryBits = extractEntryBitsV4(mem_); | ||
| final int numEntriesBytes = extractNumEntriesBytesV4(mem_); | ||
| return preLongs * Long.BYTES + numEntriesBytes + wholeBytesToHoldBits(getRetainedEntries() * entryBits); | ||
| } | ||
|
|
||
| @Override | ||
| public int getRetainedEntries(final boolean valid) { //compact is always valid | ||
| final int preLongs = extractPreLongs(mem_); | ||
| final int numEntriesBytes = extractNumEntriesBytesV4(mem_); | ||
| int offsetBytes = preLongs > 1 ? 16 : 8; | ||
| int numEntries = 0; | ||
| for (int i = 0; i < numEntriesBytes; i++) { | ||
| numEntries |= Byte.toUnsignedInt(mem_.getByte(offsetBytes++)) << (i << 3); | ||
| } | ||
| return numEntries; | ||
| } | ||
|
|
||
| @Override | ||
| public long getThetaLong() { | ||
| final int preLongs = extractPreLongs(mem_); | ||
| return (preLongs > 1) ? extractThetaLongV4(mem_) : Long.MAX_VALUE; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isEmpty() { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isOrdered() { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public HashIterator iterator() { | ||
| return new MemoryCompactCompressedHashIterator( | ||
| mem_, | ||
| (extractPreLongs(mem_) > 1 ? 16 : 8) + extractNumEntriesBytesV4(mem_), | ||
| extractEntryBitsV4(mem_), | ||
| getRetainedEntries() | ||
| ); | ||
| } | ||
|
|
||
| //restricted methods | ||
|
|
||
| @Override | ||
| long[] getCache() { | ||
| final int numEntries = getRetainedEntries(); | ||
| final long[] cache = new long[numEntries]; | ||
| int i = 0; | ||
| HashIterator it = iterator(); | ||
| while (it.next()) { | ||
| cache[i++] = it.get(); | ||
| } | ||
| return cache; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than "properly set" maybe just say it must be ordered and with the bit set to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this refers to memory byte order. Perhaps can be rephrased for clarity.