implemented merge #582
Merged
implemented merge #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-dickens
reviewed
Jul 16, 2024
| final int n = 50000; | ||
| for (int i = 0; i < n / 2; i++) { | ||
| qf1.insert(i); | ||
| qf1.insert(i + n / 2); |
There was a problem hiding this comment.
should this be qf2.insert(i + n/2)?
Otherwise there are not items in qf2 so we merge empty sketches as in the above test.
There was a problem hiding this comment.
yes, that is a mistake
c-dickens
reviewed
Jul 16, 2024
| final long quotient = fifo.element(); | ||
| final long fingerprint = other.getFingerprint(i); | ||
| final long hash = quotient << other.getFingerprintLength() | fingerprint; | ||
| System.out.println("q=" + quotient + ", fp=" + fingerprint + ", hash=" + hash); |
There was a problem hiding this comment.
Should this print statement be removed?
c-dickens
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.