expansion and some more cleanup #575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerho
reviewed
Jun 20, 2024
| import org.apache.datasketches.filters.common.BitArray; | ||
| import org.apache.datasketches.filters.common.HeapBitArray; | ||
|
|
||
| public class QuotientFilter extends Filter { | ||
|
|
||
| int bitPerEntry_; | ||
| int fingerprintLength_; | ||
| public static final double LOAD_FACTOR = 0.9; |
There was a problem hiding this comment.
Based on our discussion this morning, I think having a DEFAULT_LOAD_FACTOR and then a way for the user to set a different load factor. Based on characterization studies, the default should probably be a little lower.
leerho
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.