Common bitarray #567
Merged
Common bitarray #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to compute absolute maximum number of storage bytes required for a CompactSketch given the configured number of nominal entries (power of 2).
removed intermediate hash map
Improvements to getCompactSketchMaxBytes(...) Renaming of two special functions one in HeapQuickSelectSketch and the other in DirectQuickSelectSketchR. Also changed their access privilege.
And DirectQuickSelectSketchR::getOffHeapHashTableThreshold(..) to eliminate the unnecessary Math.floor(..) function.
Added new method
… into quotient-filter
…its API so QuotientFilter can use it
c-dickens
reviewed
May 31, 2024
src/main/java/org/apache/datasketches/filters/common/BitArray.java
Outdated
Show resolved
Hide resolved
c-dickens
reviewed
May 31, 2024
c-dickens
reviewed
May 31, 2024
src/test/java/org/apache/datasketches/filters/quotientfilter/QuotientFilterTest.java
Outdated
Show resolved
Hide resolved
c-dickens
approved these changes
May 31, 2024
AlexanderSaydakov
approved these changes
May 31, 2024
AlexanderSaydakov
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored BloomFilter's
BitArrayclass to make it common across filters. That involved making it public, so all the methods in the abstract base class now have a javadoc.BitArray now has
getBits(index, numBits)andsetBits(index, numBits, value)(where the max size is 64 bits) as well asassignBit(index, value). The QuotientFilter has been updated to use this class, and the old Bitmap wrapping some legacy CERN code has been removed.Opening this against the reviewed branch, but we probably then want to merge back into quotient-filter after that?