Added initial QF builder functions #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| //package bitmap_implementations; | ||
|
|
||
| public class QuickBitVector extends Object { |
There was a problem hiding this comment.
"extends Object" is implied (not a big deal)
| if (maxDistinctItems <= 0) { | ||
| throw new SketchesArgumentException("maxDistinctItems must be strictly positive"); | ||
| } | ||
| byte result = (byte) Math.ceil(Math.log(maxDistinctItems / 0.9) / Math.log(2)); |
There was a problem hiding this comment.
I would suggest to avoid unnamed magic numbers.
static final double loadFactor = 0.9
|
Naming is inconsistent. |
|
I understand this is just a checkpoint in a large effort, so what I mentioned above is not a stopper. |
AlexanderSaydakov
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the builder functions for quotient filter.
Splitting the PRs to avoid a large code review.