Fix: mark "Spilling (to disk) Joins" as supported in features #16343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
xudong963
reviewed
Jun 9, 2025
docs/source/user-guide/features.md
Outdated
| @@ -93,7 +93,7 @@ | |||
| - [x] Memory limits enforced | |||
| - [x] Spilling (to disk) Sort | |||
| - [x] Spilling (to disk) Grouping | |||
| - [ ] Spilling (to disk) Joins | |||
| - [x] Spilling (to disk) Joins | |||
There was a problem hiding this comment.
I think we should split the Join into different physical join implementations, such as sort merge join, hash join and so on.
Spilling (to disk) sort merge join ✅
Spilling (to disk) hash join ❌
There was a problem hiding this comment.
This is a good suggestion 👍
…illing (to disk) Sort Merge Join"
xudong963
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The feature matrix in the user guide was missing an updated status for join spilling support. This PR ensures that the documentation reflects the current capabilities of the system, improving clarity for users and maintainers.
What changes are included in this PR?
[x]).Are these changes tested?
Are there any user-facing changes?