-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Always add parentheses when formatting BinaryExpr
with SchemaDisplay
#16209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hendrikmakait
wants to merge
14
commits into
apache:main
Choose a base branch
from
hendrikmakait:fix-schemadisplay-for-nested-binaryexprs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5d3e422
Fix ScdhemaDisplay
hendrikmakait 6b30b4f
Add test
hendrikmakait 085bf74
linting
hendrikmakait fdbfa36
Always add parantheses
hendrikmakait e7aa204
Additional test case
hendrikmakait 378b969
Adjust tests
hendrikmakait 1c9c48a
more tests
hendrikmakait 8b1f34c
additional tests
hendrikmakait 0981c99
More tests
hendrikmakait a7769e8
sqllogictests
hendrikmakait 6d85f17
Adjust example
hendrikmakait eab812a
Adjust TPC-H
hendrikmakait 0e5d595
Merge branch 'main' into fix-schemadisplay-for-nested-binaryexprs
hendrikmakait 1c73c3d
Merge branch 'main' into fix-schemadisplay-for-nested-binaryexprs
hendrikmakait File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual change.