-
Notifications
You must be signed in to change notification settings - Fork 1.5k
TopK dynamic filter pushdown attempt 2 #15770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,004
−61
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3c23d91
implement dynamic filter pushdown for topk operator
adriangb e5979d6
fix some tests
adriangb d8670de
lint
adriangb 2f5ce85
pass around the filter in EnforceSorting optimizer rule
adriangb 66f6407
check that filter pushdown happened in fuzz tests
adriangb 5cb49d2
fmt
adriangb 9eea14c
revert accidental change
adriangb 907d0a3
remove indentation
adriangb a5f300c
remove outdated comment
adriangb 7887f3f
add example to docstring
adriangb 18a2ba8
fix doctest
adriangb a90781f
Filter TopK inputs based on dynamic topk filter
Dandandan 53ab9ab
Clippy
Dandandan 746cc2f
Fast path
Dandandan 14a996d
Fix test
Dandandan ebe5b80
Fix
Dandandan 6832526
Adapt comment
Dandandan 5ad57fe
Split filter pushdown into two phases
adriangb 938c129
more docs
adriangb 3463c44
fmt
adriangb c719676
revert unecessary change
adriangb 4a3e3c3
docs, naming
adriangb cd56084
add links
adriangb 7badc1e
update plans
adriangb 8e88bd9
clippy
adriangb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could also extend non-scan operators with the dynamic filter pushdown?
It would be interesting to extend filters / aggregates / joins / etc. with the support of this as well...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would the idea be to prune hash table state, for example, if we knew some of the groups were no longer needed?
I do think implementing more "late materialization" (aka turn on filter_pushdown) will help too