Skip to content

Replace println! with assert! if possible in DataFusion examples #11237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 5, 2024
Merged

Replace println! with assert! if possible in DataFusion examples #11237

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
284f05c
Replace println! with assert! if possible in DataFusion examples
Nishi46 Jul 3, 2024
a662d38
Replace println! with assert! if possible in DataFusion examples
Nishi46 Jul 3, 2024
eb0ea4e
Merge branch 'apache:main' into nishi_branch
Nishi46 Jul 3, 2024
36d0b14
Update rewrite_expr.rs
Nishi46 Jul 3, 2024
6fb863f
Merge remote-tracking branch 'apache/main' into nishi_branch
alamb Jul 5, 2024
b6401ed
port changes to other examples
alamb Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 32 additions & 25 deletions datafusion-examples/examples/optimizer_rule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use arrow::array::{ArrayRef, Int32Array, RecordBatch, StringArray};
use arrow_schema::DataType;
use datafusion::prelude::SessionContext;
use datafusion_common::tree_node::{Transformed, TreeNode};
use datafusion_common::{Result, ScalarValue};
use datafusion_common::{assert_batches_eq, Result, ScalarValue};
use datafusion_expr::{
BinaryExpr, ColumnarValue, Expr, LogicalPlan, Operator, ScalarUDF, ScalarUDFImpl,
Signature, Volatility,
Expand Down Expand Up @@ -54,39 +54,46 @@ pub async fn main() -> Result<()> {

// We can see the effect of our rewrite on the output plan that the filter
// has been rewritten to `my_eq`
//
// Filter: my_eq(person.age, Int32(22))
// TableScan: person projection=[name, age]
println!("Logical Plan:\n\n{}\n", plan.display_indent());
assert_eq!(
plan.display_indent().to_string(),
"Filter: my_eq(person.age, Int32(22))\
\n TableScan: person projection=[name, age]"
);

// The query below doesn't respect a filter `where age = 22` because
// the plan has been rewritten using UDF which returns always true
//
// And the output verifies the predicates have been changed (as the my_eq
// function always returns true)
//
// +--------+-----+
// | name | age |
// +--------+-----+
// | Andy | 11 |
// | Andrew | 22 |
// | Oleks | 33 |
// +--------+-----+
ctx.sql(sql).await?.show().await?;
assert_batches_eq!(
[
"+--------+-----+",
"| name | age |",
"+--------+-----+",
"| Andy | 11 |",
"| Andrew | 22 |",
"| Oleks | 33 |",
"+--------+-----+",
],
&ctx.sql(sql).await?.collect().await?
);

// however we can see the rule doesn't trigger for queries with predicates
// other than `=`
//
// +-------+-----+
// | name | age |
// +-------+-----+
// | Andy | 11 |
// | Oleks | 33 |
// +-------+-----+
ctx.sql("SELECT * FROM person WHERE age <> 22")
.await?
.show()
.await?;
assert_batches_eq!(
[
"+-------+-----+",
"| name | age |",
"+-------+-----+",
"| Andy | 11 |",
"| Oleks | 33 |",
"+-------+-----+",
],
&ctx.sql("SELECT * FROM person WHERE age <> 22")
.await?
.collect()
.await?
);

Ok(())
}
Expand Down