feat: support export data for bigquery #1976
Open
+313
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 25, 2025
| /// EXPORT DATA OPTIONS(uri='gs://bucket/folder/*', format='PARQUET', overwrite=true) AS | ||
| /// SELECT field1, field2 FROM mydataset.table1 ORDER BY field1 LIMIT 10 | ||
| /// ``` | ||
| ExportData(ExportData), |
There was a problem hiding this comment.
Could we add a link to the bigquery docs where the syntax comes from?
src/parser/mod.rs
Outdated
| @@ -645,6 +645,7 @@ impl<'a> Parser<'a> { | |||
| Keyword::COMMENT if self.dialect.supports_comment_on() => self.parse_comment(), | |||
| Keyword::PRINT => self.parse_print(), | |||
| Keyword::RETURN => self.parse_return(), | |||
| Keyword::EXPORT => self.parse_export(), | |||
There was a problem hiding this comment.
Could we do similar to here where we call prev_token() so that the parse-export() function is stand alone and able to parse a complete statement?
src/parser/mod.rs
Outdated
| @@ -16510,6 +16511,27 @@ impl<'a> Parser<'a> { | |||
| } | |||
| } | |||
|
|
|||
| fn parse_export(&mut self) -> Result<Statement, ParserError> { | |||
There was a problem hiding this comment.
Suggested change
| fn parse_export(&mut self) -> Result<Statement, ParserError> { | |
| fn parse_export_date(&mut self) -> Result<Statement, ParserError> { |
Could we also add a short description mentioning that this parses a Statement::ExportData statement? For example
tests/sqlparser_bigquery.rs
Outdated
| @@ -2566,3 +2566,24 @@ fn test_struct_trailing_and_nested_bracket() { | |||
| ) | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_export() { | |||
There was a problem hiding this comment.
Since this introduces a new statement, can we include an assertion on the AST for one of the statements, checking that the returned AST looks like what we expect? For example
Also could we add coverage for some scenarios like the following?
"EXPORT DATA OPTIONS()";
"EXPORT DATA AS SELECT ...";
"EXPORT DATA WITH CONNECTION ... AS SELECT ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.