Snowflake: CREATE DYNAMIC TABLE #1960
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Jul 23, 2025
tests/sqlparser_snowflake.rs
Outdated
| fn parse_create_dynamic_table() { | ||
| snowflake().verified_stmt(r#"CREATE OR REPLACE DYNAMIC TABLE my_dynamic_table TARGET_LAG='20 minutes' WAREHOUSE=mywh AS SELECT product_id, product_name FROM staging_table"#); | ||
| snowflake() | ||
| .parse_sql_statements( |
There was a problem hiding this comment.
For the usages of parse_sql_statements can we instead use snowflake().one_statement_parses_to(sql, canonical) in the cases that verified_stmt isnt applicable?
| @@ -1104,6 +1066,56 @@ fn parse_sf_create_table_or_view_with_dollar_quoted_comment() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn parse_create_dynamic_table() { | |||
There was a problem hiding this comment.
Can we include scenarios for the BEFORE and RefreshMode variants? those don't seem to be covered by the existing tests?
yoavcloud
force-pushed
the
sf_create_dynamic_table
branch
from
c314bdd to
e6dbd03
Compare
iffyio
reviewed
Jul 24, 2025
| "CREATE DYNAMIC TABLE my_dynamic_table", | ||
| " TARGET_LAG='DOWNSTREAM'", | ||
| " WAREHOUSE=mywh", | ||
| " REFRESH_MODE=AUTO", |
There was a problem hiding this comment.
Can we add similar coverage for REFRESH_MODE=FULL and REFRESH_MODE=INCREMENTAL?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for
CREATE DYNAMIC TABLEin Snowflake:CreateTableBuilderwith new optionsCreateTableBuilder::validate_schema_infofunction and related tests because, in my opinion, it introduces semantic validation, which is out of scope for the parser.