Skip to content

Postgres: Support parenthesized SET options for ALTER TABLE #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

Postgres: Support parenthesized SET options for ALTER TABLE #1947

merged 5 commits into from
Jul 23, 2025

Conversation

achristmascarl
Copy link
Contributor

Closes #1946

iffyio
iffyio reviewed Jul 17, 2025
View reviewed changes
@achristmascarl achristmascarl requested a review from iffyio July 18, 2025 14:56
iffyio
iffyio reviewed Jul 21, 2025
View reviewed changes
@iffyio iffyio changed the title Postgres: ALTER TABLE SET ( storage_parameters ) Postgres: Support parenthesized SET options for ALTER TABLE Jul 21, 2025
@achristmascarl @iffyio
update comment docs
9ae0afb 
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
@achristmascarl achristmascarl requested a review from iffyio July 21, 2025 14:01
iffyio
iffyio approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @achristmascarl!
cc @alamb

@iffyio iffyio merged commit f49c30f into apache:main Jul 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iffyio iffyio iffyio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres ALTER TABLE SET ( storage_parameter [= value] [, ... ] ) fails to parse
2 participants
@achristmascarl @iffyio