chore: Refactor GetArrayItem, ElementAt, GetArrayStructFields out of QueryPlanSerde #2026
+103
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of QueryPlanSerde
petern48
changed the title
andygrove
reviewed
Jul 12, 2025
Comment on lines
1861
to
1878
| case _ @ArrayFilter(_, func) if func.children.head.isInstanceOf[IsNotNull] => | ||
| convert(CometArrayCompact) | ||
| case _: ArrayExcept => | ||
| convert(CometArrayExcept) | ||
| case Rand(child, _) => | ||
| createUnaryExpr( | ||
| expr, | ||
| child, | ||
| inputs, | ||
| binding, | ||
| (builder, unaryExpr) => builder.setRand(unaryExpr)) | ||
| case expr => | ||
| QueryPlanSerde.exprSerdeMap.get(expr.getClass) match { | ||
| case Some(handler) => convert(handler) | ||
| case _ => | ||
| withInfo(expr, s"${expr.prettyName} is not supported", expr.children: _*) | ||
| None | ||
| } |
There was a problem hiding this comment.
I don't think that this section should be deleted
There was a problem hiding this comment.
Yes, you're definitely right. Sorry, I think I (incorrectly) assumed I was working at the bottom of the list and deleted those without realizing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2026 +/- ##
=============================================
- Coverage 56.12% 38.84% -17.28%
+ Complexity 976 887 -89
=============================================
Files 119 134 +15
Lines 11743 13046 +1303
Branches 2251 2385 +134
=============================================
- Hits 6591 5068 -1523
- Misses 4012 6996 +2984
+ Partials 1140 982 -158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2019
Rationale for this change
See #2019
What changes are included in this PR?
Refactor GetArrayItem, ElementAt, GetArrayStructFields out of QueryPlanSerde
How are these changes tested?
No new tests are needed since this is a refactor