feat: add CopyExec and move CopyExec handling to Spark #2001
+151
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbutrovich I would appreciate it if you could take a look at this PR and provide some early feedback on whether I'm headed in the right direction |
|
Yep, I think this is headed in the right direction. Really anywhere you see us having hard-coded rules about inserting CopyExec in planner.rs we'd like to have consolidated down to a more concise, modifiable function on the Scala side. This looks to be going that way. |
Thanks for the feedback @mbutrovich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1995
Rationale for this change
What changes are included in this PR?
How are these changes tested?