Skip to content

feat: Upgrade to the official DataFusion 49.0.0 release #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dharanad
Copy link
Contributor

@dharanad dharanad commented Jul 8, 2025

Which issue does this PR close?

Closes #1993

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@dharanad dharanad marked this pull request as ready for review July 8, 2025 09:04
@dharanad dharanad marked this pull request as draft July 8, 2025 09:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.82%. Comparing base (f09f8af) to head (7632870).
Report is 328 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1997       +/-   ##
=============================================
- Coverage     56.12%   42.82%   -13.31%     
- Complexity      976     1040       +64     
=============================================
  Files           119      134       +15     
  Lines         11743    13102     +1359     
  Branches       2251     2396      +145     
=============================================
- Hits           6591     5611      -980     
- Misses         4012     6437     +2425     
+ Partials       1140     1054       -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dharanad
Copy link
Contributor Author

Will resume the work on this issue tmrw my time.

@dharanad dharanad marked this pull request as ready for review July 15, 2025 12:02
@@ -38,8 +38,8 @@ arrow = { version = "55.1.0", features = ["prettyprint", "ffi", "chrono-tz"] }
async-trait = { version = "0.1" }
bytes = { version = "1.10.0" }
parquet = { version = "55.1.0", default-features = false, features = ["experimental"] }
datafusion = { version = "48.0.0", default-features = false, features = ["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] }
datafusion-spark = { version = "48.0.0" }
datafusion = { git = "https://github.com/apache/datafusion", rev = "3291e4e", default-features = false, features = ["unicode_expressions", "crypto_expressions", "nested_expressions", "parquet"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title mentions Upgrade to the official Datafusion 49.0.0 release, however it looks like version 49.0.0 hasn't been officially released yet (apache/datafusion#16235)?

Will this change be on hold until the release is finalized? Or is the plan to update Comet to revision 3291e4e in this PR, and then follow up with a separate PR once 49.0.0 is released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isnt the PR to update Comet to revision 3291e4e. This is a incremental PR to update DF verion to 49.0.0 PTAL #1993

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to DataFusion 49.0.0
3 participants