-
Notifications
You must be signed in to change notification settings - Fork 225
fix: Fix overflow handling when casting float to decimal #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1914 +/- ##
============================================
+ Coverage 56.12% 58.96% +2.83%
- Complexity 976 1141 +165
============================================
Files 119 130 +11
Lines 11743 12865 +1122
Branches 2251 2420 +169
============================================
+ Hits 6591 7586 +995
- Misses 4012 4059 +47
- Partials 1140 1220 +80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Would you like to add a unit test to cover this case? |
Ok, do it later. |
Thanks @leung-ming, for the test on the native side. I was really thinking of a unit test in |
The CI test failure is unrelated to changes in this PR and is now fixed in main branch |
The CI failure can be fixed by merging latest from main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @leung-ming
Which issue does this PR close?
Rationale for this change
The
continue
afterappend_null
was forgottenWhat changes are included in this PR?
Add
continue
How are these changes tested?
org.apache.comet.CometCastSuite