Skip to content

fix: Fix overflow handling when casting float to decimal #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025

Conversation

leung-ming
Copy link
Contributor

Which issue does this PR close?

Rationale for this change

The continue after append_null was forgotten

What changes are included in this PR?

Add continue

How are these changes tested?

org.apache.comet.CometCastSuite

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.96%. Comparing base (f09f8af) to head (eb3953e).
Report is 282 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1914      +/-   ##
============================================
+ Coverage     56.12%   58.96%   +2.83%     
- Complexity      976     1141     +165     
============================================
  Files           119      130      +11     
  Lines         11743    12865    +1122     
  Branches       2251     2420     +169     
============================================
+ Hits           6591     7586     +995     
- Misses         4012     4059      +47     
- Partials       1140     1220      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@parthchandra
Copy link
Contributor

Would you like to add a unit test to cover this case?

@leung-ming
Copy link
Contributor Author

Would you like to add a unit test to cover this case?

Ok, do it later.

@parthchandra
Copy link
Contributor

Thanks @leung-ming, for the test on the native side. I was really thinking of a unit test in org.apache.comet.CometCastSuite

@andygrove
Copy link
Member

The CI test failure is unrelated to changes in this PR and is now fixed in main branch

@andygrove
Copy link
Member

The CI failure can be fixed by merging latest from main branch.

@leung-ming leung-ming changed the title fix: Add continue after append_null when casting float to decimal fix: Fix overflow handling when casting float to decimal Jun 24, 2025
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leung-ming

@andygrove andygrove merged commit 1f3af8f into apache:main Jun 27, 2025
84 of 85 checks passed
@leung-ming leung-ming deleted the nit branch June 28, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants