CXF-9107 Clean up coverity resource leaks and a javascript method typo #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reta
reviewed
Feb 3, 2025
integration/jca/src/main/java/org/apache/cxf/jca/core/classloader/PlugInClassLoader.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Feb 3, 2025
rt/javascript/javascript-rt/src/main/resources/org/apache/cxf/javascript/cxf-utils.js
Show resolved
Hide resolved
reta
reviewed
Feb 3, 2025
| } else { | ||
| response = checkAdapter(response, type, anns, false); | ||
| } | ||
| realStream.close(); |
There was a problem hiding this comment.
So this may not work: the stream is not created here and should not be closed here
There was a problem hiding this comment.
Can we do this within a try-with-resources?
There was a problem hiding this comment.
I am pretty sure it is being done this way (higher in the stack), when the request / response body is being processed
There was a problem hiding this comment.
@cunningt could you please revert this one change and we are good to go, as per spec:
The caller is responsible for ensuring that the input stream ends when the entity has been consumed. The implementation should not close the input stream.
reta
reviewed
Feb 3, 2025
rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/persistence/jdbc/RMTxStore.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CXF-9107
Clean up coverity resource leaks (inputstream and resultset) and a javascript method typo