nouveau: use http/2 #5598
Merged
nouveau: use http/2 #5598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
61c03f9 to
92bd607
Compare
|
had to eliminate the 204 responses due to ninenines/cowlib#140 so instead of no resp body I send |
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
92bd607 to
8284c7c
Compare
|
should address the issue in #5597 also. with http/2 each couchdb node has one tcp connection to the nouveau server and multiplexes index update and search requests in it. |
rnewson
force-pushed
the
nouveau-gun-http2
branch
3 times, most recently
from
37883dc to
d58ea64
Compare
nickva
reviewed
Jul 16, 2025
rebar.config.script
Outdated
| @@ -158,6 +158,8 @@ DepDescs = [ | |||
| {fauxton, {url, "https://github.com/apache/couchdb-fauxton"}, | |||
| {tag, "v1.3.4"}, [raw]}, | |||
| {ibrowse, "ibrowse", {tag, "CouchDB-4.4.2-6"}}, | |||
| {gun, {url, "https://github.com/ninenines/gun"}, | |||
There was a problem hiding this comment.
We'd probably want to mirror the dependency I think those are the ASF rules. For some repos like proper we don't do it because they are not part of the final release.
nickva
approved these changes
Jul 16, 2025
rnewson
force-pushed
the
nouveau-gun-http2
branch
2 times, most recently
from
273a353 to
0c7f7e5
Compare
big-r81
reviewed
Jul 16, 2025
configure
Outdated
There was a problem hiding this comment.
Don’t forget to update configure.ps1 too.
There was a problem hiding this comment.
done but no way to validate
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
0c7f7e5 to
cc98567
Compare
we lose the pipelining benefit for indexing as http/2 does not support it but we benefit from far fewer connections between couchdb and nouveau server.
rnewson
force-pushed
the
nouveau-gun-http2
branch
from
cc98567 to
2578b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we lose the pipelining benefit for indexing as http/2 does not support it (and we need the requests that update the index to happen in the order we issue them).