-
Notifications
You must be signed in to change notification settings - Fork 995
Fix #1232: Reload issue resulting in white screen #1533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1533 +/- ##
=======================================
Coverage 81.28% 81.28%
=======================================
Files 16 16
Lines 1875 1875
=======================================
Hits 1524 1524
Misses 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If we look at the bigger scope beyond the Meteor bug, it seems to me like the current behaviour is what most apps would want in most cases. If you switch away from a Cordova app, and the webview gets killed in the background, when you resume it you would expect to be on the same page you were previously, and not have the app reload from the start. Whether that actually works in practice or not is a good question. We know that it seemingly doesn't work in the case of Meteor, but I'm interested to know if other apps are seeing similar problems. I'd prefer to keep the best possible user experience for the widest set of apps, rather than changing the experience for everyone just to work around a Meteor bug. |
I'm not sure if this works in practice, cause when this occurs in my apps, it effectively restarts to the main entry point. If the webview gets killed you lose all JS runtime state, unless if you explicitly store the state somewheres semi-persistent. But in all likeliness, in my case it's probably something within my own framework that puts the app to the "main screen" on reload/refresh.
This is likely a common issue in apps though, depending on the app complexity, and maybe is the root cause of meteor (have 0 experience with MeteorJS) |
For all those coming for the meteor solution, we are trying to override this at the Meteor build level until this gets merged. cordova-build-override/platforms/ios/CordovaLib/include/Cordova/CDVViewController.h cordova-build-override/platforms/ios/CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m You need to copy and paste these two files into your current project using these paths. |
![]() This line is failing as of today. @abroa01 is working on root causing how to get this build working with Meteor 3.3. |
Platforms affected
IOS
Motivation and Context
It addresses the reload issue resulting in a white screen on IOS (Meteor framework )
Description
#1235
This is a fork with conflict resolved on existing PR
Testing
I used the changes with my Meteor/Cordova app on different iOS devices and I could not detect any white screen.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)