Review create
default values and small rework
#1100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Mixed default values for
create
between cli doc, cordova-android and cordova-ios.Description
Package ids were mostly correct but not all, and same for project name. Suggested proper defaults:
io.cordova.helloCordova
Hello Cordova
See linked PRs: apache/cordova-cli#554, apache/cordova-android#1213
And
createProject
on how to init and deal with its parametersremove useless check on project_parent asfs.ensureDirSync
is used(see each commit for detail on my steps)
Testing
npm test
successChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)