Skip to content

Conversation

danhaywood
Copy link
Contributor

No description provided.

@danhaywood danhaywood requested a review from Copilot April 14, 2025 13:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

core/codegen-bytebuddy/src/main/java/org/apache/causeway/core/codegen/bytebuddy/services/ProxyFactoryServiceByteBuddy.java:59

  • Using InvocationHandler as the cache key assumes that handlers have proper equals/hashCode implementations. Consider using a stable identifier or ensure that all custom InvocationHandler instances override equals/hashCode to avoid potential cache collisions.
private Map<InvocationHandler, Class<?>> proxyClassByInvocationHandler = _Maps.newConcurrentHashMap();

@andi-huber
Copy link
Contributor

I'm working on merging those changes from #2926 and #2953 into main.
Its partly done. Wrapper proxy class caching not done yet ... working on it.
(Idea and implementation are looking good to me.)

@danhaywood danhaywood merged commit 99aa1bf into maintenance-branch Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants