CASSANDRA-20974: Heap dump should not be generated on handled exceptions [5.0]

[pauloricardomg]

Thanks for sending a pull request! Here are some tips if you're new here:

• Ensure you have added or run the appropriate tests for your PR.
• Be sure to keep the PR description updated to reflect all changes.
• Write your PR title to summarize what this PR proposes.
• If possible, provide a concise example to reproduce the issue for a faster review.
• Read our contributor guidelines
• If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

[isaacreath]

+1 (nb). Comment is pretty minor.

[isaacreath]

A comment could be helpful here so it's clear why we check DatabaseDescriptor.getDumpHeapOnUncaughtException() outside of HeapUtils.maybeCreateHeapDump so that nobody accidentally deletes this check thinking it's redundant.