Performance/memory optimizations, stability/bug fixes, and small enhancements #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
popduke
commented
Oct 14, 2025
popduke
commented
- Optimizations:
- Reduce reset and I/O overhead in InboxStore/DistWorker
- Optimize TopicLevelTrie to reduce remove overhead
- Dynamic sending window for QoS1/2 messages
- Fixes:
- Fix range lookup key in InboxCheckSubScheduler
- Enforce strict FIFO for permission checks
- Conditionally clear batch-call state to avoid task leaks
- Fix DistWorkerCleaner halting
- Schedule on-demand hint/confirm timeout to keep the fetch loop running
- Enhancements:
- Add API to retrieve inbox state
- Report drop events on delete
- New event for successful retained-message matching
- RedundantRangeRemovalBalancer detects and removes zombie ranges
- Add @JsonMerge to service config classes to simplify config merging
2. Simplify client range router patching mechanism
… and reduce memory overhead
2. Only report tenant metrics from leader co-proc
2. adjust default values of gc params
1. do not early confirm when single node 2. reduce message complexity
2. Fix potential consistency issue in TenantRouteCache and TopicIndex
2. try drain staging buffer immediately after buffering message
…config file complexity further
base-scheduler/src/main/java/org/apache/bifromq/basescheduler/Batcher.java
Show resolved
Hide resolved
| } | ||
| List<CompletableFuture<Void>> distFutures = new LinkedList<>(); | ||
| ConcurrentMap<String, TopicFanout.Builder> tenantTopicFanOuts = new ConcurrentHashMap<>(); | ||
| ConcurrentMap<String, Map<String, AtomicInteger>> tenantTopicFanOuts = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
It looks like "tenantTopicFanOuts" is a local var, is it possiable to use HashMap and Integer for fanout tracking?
|
|
||
| public void reset(boolean abort) { | ||
| if (abort) { | ||
| batchedTasks = new LinkedList<>(); |
There was a problem hiding this comment.
For batch schedulers, some are Dequeue with length limit some are unbounded. Here is a linked list. So what is the design tradeoff behind that?
Gujiawei-Edinburgh
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.