Skip to content

Add exception handling for ProxyProtocolHandler and reduce log level for MQTTPreludeHandler #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

Add exception handling for ProxyProtocolHandler and reduce log level for MQTTPreludeHandler #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...bifromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/MQTTPreludeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,14 +199,14 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
ctx.pipeline().remove(this);
break;
default:
log.warn("Unsupported protocol version: {}", connectMessage.variableHeader().version());
log.debug("Unsupported protocol version: {}", connectMessage.variableHeader().version());
}
}

@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
// simple strategy: shutdown the channel directly
log.warn("ctx: {}, cause:", ctx, cause);
log.debug("ctx: {}, cause:", ctx, cause);
eventCollector.report(getLocal(ChannelError.class).peerAddress(remoteAddr).cause(cause));
ctx.channel().close();
}
Expand Down
9 changes: 9 additions & 0 deletions ...fromq-mqtt-server/src/main/java/org/apache/bifromq/mqtt/handler/ProxyProtocolHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,16 @@
import io.netty.channel.ChannelInboundHandlerAdapter;
import io.netty.channel.ChannelPipeline;
import io.netty.handler.codec.haproxy.HAProxyMessage;
import lombok.extern.slf4j.Slf4j;

import java.net.InetSocketAddress;
import java.util.Iterator;
import java.util.Map;

/**
* This handler is used to parse the HAProxy protocol message and extract the real IP and port of the client.
*/
@Slf4j
public class ProxyProtocolHandler extends ChannelInboundHandlerAdapter {

@Override
Expand Down Expand Up @@ -73,4 +76,10 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
ctx.pipeline().remove(this);
}
}

@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception {
log.debug("ctx: {}, cause:", ctx, cause);
}

}
Loading