Skip to content

1. add a DeleteCallScheduler for current batching message overriding. #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

1. add a DeleteCallScheduler for current batching message overriding. #114

merged 2 commits into from
Feb 7, 2025

Conversation

Gujiawei-Edinburgh
Copy link
Contributor

No description provided.

@Gujiawei-Edinburgh Gujiawei-Edinburgh marked this pull request as draft February 4, 2025 08:58
@Gujiawei-Edinburgh Gujiawei-Edinburgh marked this pull request as ready for review February 4, 2025 08:58
@Gujiawei-Edinburgh Gujiawei-Edinburgh marked this pull request as draft February 5, 2025 03:03
@Gujiawei-Edinburgh Gujiawei-Edinburgh marked this pull request as ready for review February 5, 2025 03:04
@Gujiawei-Edinburgh
1. renaming the bacher name in delete scheduler;
491844f 
2. close the delete scheduler when retain service is closing;
3. change storeClient name in BatchRetainCall.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13182108658

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 57 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.009%) to 65.723%
Files with Coverage Reduction New Missed Lines %
com/baidu/bifromq/dist/trie/TopicFilterIterator.java 1 75.57%
com/baidu/bifromq/inbox/store/InboxStore.java 1 83.33%
com/baidu/bifromq/basecrdt/store/AntiEntropy.java 1 83.16%
com/baidu/bifromq/basekv/client/scheduler/BatchQueryCall.java 2 72.09%
com/baidu/bifromq/retain/store/RetainStoreCoProc.java 2 90.86%
com/baidu/bifromq/basekv/raft/exception/ReadIndexException.java 3 78.57%
com/baidu/bifromq/basekv/raft/RaftNodeStateLeader.java 3 86.52%
com/baidu/bifromq/inbox/server/scheduler/BatchInsertCall.java 4 75.0%
com/baidu/bifromq/basecluster/transport/TCPTransport.java 5 87.06%
com/baidu/bifromq/basekv/raft/RaftNodeState.java 6 90.82%
Totals Coverage Status
Change from base Build 12947092210: -0.009%
Covered Lines: 22392
Relevant Lines: 33085
💛 - Coveralls

@popduke popduke merged commit ac911bc into apache:main Feb 7, 2025
1 check failed
@Gujiawei-Edinburgh Gujiawei-Edinburgh deleted the feat-retain-handling branch February 7, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@popduke popduke popduke approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gujiawei-Edinburgh @coveralls @popduke