-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-38914: [Python] Add EncryptionConfiguration.uniform_encryption #46347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-38914: [Python] Add EncryptionConfiguration.uniform_encryption #46347
Conversation
266781f
to
b78e6e2
Compare
GDB test failures seem unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @MartinNowak. PR looks good to me.
Only one nit - if I understand correctly uniform_encryption
defaults to False
so encrypting with:
encryption_config = pe.EncryptionConfiguration(
footer_key=FOOTER_KEY_NAME,
encryption_algorithm="AES_GCM_V1",
cache_lifetime=timedelta(minutes=5.0),
data_key_length_bits=256)
Should raise: "Either column_keys or uniform_encryption must be set"
. Could we add test for that?
Thanks for the quick review @rok. That was already tested. arrow/python/pyarrow/tests/parquet/test_encryption.py Lines 253 to 267 in b78e6e2
|
Oh yeah, you're right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to go.
Pinging @pitrou to double check me :).
The gdb issue seems unrelated. |
b78e6e2
to
5c0894c
Compare
Assuming CI passes I'll merge @pitrou |
- expose missing EncryptionConfiguration parameter in pyarrow
5c0894c
to
e38abd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for this @MartinNowak
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 6ab37dd. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
Support uniform encryption when writing parquet files.
What changes are included in this PR?
Exposing EncryptionConfiguration.uniform_encryption to pyarrow.
Are these changes tested?
Yes, see included tests.
Are there any user-facing changes?
Addition of uniform_encryption parameter to EncryptionConfiguration.