-
Notifications
You must be signed in to change notification settings - Fork 6
chore: add missing write permission to push built Docker images #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be because it's the first time? We don't seem to have write permissions on others, like:
https://github.com/apache/arrow/blob/a974df4f2f11cf404c88df083d74a71aa463cfb9/.github/workflows/cpp.yml#L147-L152
apache/arrow uses Docker Hub not ghcr.io and Docker Hub user account is here: https://github.com/apache/arrow/blob/a974df4f2f11cf404c88df083d74a71aa463cfb9/.github/workflows/cpp.yml#L154-L155 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If just updating the permission doesn't work it's probably the user name.
github.actor
afaik would be kou
(for this PR) but the required login would be apache
which you can get through github.repository_owner
Alternatively we might need to ask infra to enable the package permissions for this repo? But I feel like that defaults to enabled. |
Co-authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Hmm. Auto-generated GitHub Token may be for FYI: ADBC uses https://github.com/apache/arrow-adbc/actions/runs/15668872626/job/44136690901#step:8:1
|
apache/arrow-java#476 may be related but let's try with this. If we can't push, let's ask INFRA. |
Ah, ok! Then it's probably just the missing scope :) |
Worked: https://github.com/apache/arrow-swift/actions/runs/15693333885/job/44213242144#step:9:849
|
https://github.com/apache/arrow-swift/pkgs/container/arrow-swift-dev is public. It must be available from forks. |
What's Changed
Override permission in the
docker
job.Closes #37.